Adnuntius: Add Price Type #3084
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| { | ||
| "mockBidRequest": { | ||
| "id": "test-request-id", | ||
| "user": { | ||
| "id": "1kjh3429kjh295jkl" | ||
| }, | ||
| "imp": [ | ||
| { | ||
| "id": "test-imp-id", | ||
| "banner": { | ||
| "format": [ | ||
| { | ||
| "w": 300, | ||
| "h": 250 | ||
| }, | ||
| { | ||
| "w": 300, | ||
| "h": 600 | ||
| } | ||
| ] | ||
| }, | ||
| "ext": { | ||
| "bidder": { | ||
| "auId": "123", | ||
| "priceType": "gross" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "httpCalls": [ | ||
| { | ||
| "expectedRequest": { | ||
| "uri": "http://whatever.url?format=json&tzo=0", | ||
| "body": { | ||
| "adUnits": [ | ||
| { | ||
| "auId": "123", | ||
| "targetId": "123-test-imp-id", | ||
| "dimensions": [[300,250],[300,600]] | ||
| } | ||
| ], | ||
| "metaData": { | ||
| "usi": "1kjh3429kjh295jkl" | ||
| }, | ||
| "context": "unknown" | ||
| } | ||
| }, | ||
| "mockResponse": { | ||
| "status": 200, | ||
| "body": { | ||
| "adUnits": [ | ||
| { | ||
| "auId": "0000000000000123", | ||
| "targetId": "123-test-imp-id", | ||
| "html": "<ADCODE>", | ||
| "responseId": "adn-rsp-900646517", | ||
| "ads": [ | ||
| { | ||
| "destinationUrls": { | ||
| "url": "http://www.google.com" | ||
| }, | ||
| "bid": { "amount": 20.0, "currency": "NOK" }, | ||
| "grossBid": {"amount": 0.1, "currency": "NOK"}, | ||
| "netBid": {"amount": 0.075, "currency": "NOK"}, | ||
| "adId": "adn-id-1559784094", | ||
| "creativeWidth": "980", | ||
| "creativeHeight": "240", | ||
| "creativeId": "jn9hpzvlsf8cpdmm", | ||
| "lineItemId": "q7y9qm5b0xt9htrv" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "expectedBidResponses": [ | ||
| { | ||
| "bids": [ | ||
| { | ||
| "bid": { | ||
| "id": "adn-id-1559784094", | ||
| "impid": "test-imp-id", | ||
| "price": 100, | ||
| "adm": "<ADCODE>", | ||
| "adid": "adn-id-1559784094", | ||
| "adomain": [ | ||
| "google.com" | ||
| ], | ||
| "cid": "q7y9qm5b0xt9htrv", | ||
| "crid": "jn9hpzvlsf8cpdmm", | ||
| "w": 980, | ||
| "h": 240 | ||
| }, | ||
| "type": "banner" | ||
| } | ||
| ], | ||
| "currency": "NOK" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| { | ||
| "mockBidRequest": { | ||
| "id": "test-request-id", | ||
| "user": { | ||
| "id": "1kjh3429kjh295jkl" | ||
| }, | ||
| "imp": [ | ||
| { | ||
| "id": "test-imp-id", | ||
| "banner": { | ||
| "format": [ | ||
| { | ||
| "w": 300, | ||
| "h": 250 | ||
| }, | ||
| { | ||
| "w": 300, | ||
| "h": 600 | ||
| } | ||
| ] | ||
| }, | ||
| "ext": { | ||
| "bidder": { | ||
| "auId": "123", | ||
| "priceType": "net" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "httpCalls": [ | ||
| { | ||
| "expectedRequest": { | ||
| "uri": "http://whatever.url?format=json&tzo=0", | ||
| "body": { | ||
| "adUnits": [ | ||
| { | ||
| "auId": "123", | ||
| "targetId": "123-test-imp-id", | ||
| "dimensions": [[300,250],[300,600]] | ||
| } | ||
| ], | ||
| "metaData": { | ||
| "usi": "1kjh3429kjh295jkl" | ||
| }, | ||
| "context": "unknown" | ||
| } | ||
| }, | ||
| "mockResponse": { | ||
| "status": 200, | ||
| "body": { | ||
| "adUnits": [ | ||
| { | ||
| "auId": "0000000000000123", | ||
| "targetId": "123-test-imp-id", | ||
| "html": "<ADCODE>", | ||
| "responseId": "adn-rsp-900646517", | ||
| "ads": [ | ||
| { | ||
| "destinationUrls": { | ||
| "url": "http://www.google.com" | ||
| }, | ||
| "bid": { "amount": 20.0, "currency": "NOK" }, | ||
| "grossBid": {"amount": 0.1, "currency": "NOK"}, | ||
| "netBid": {"amount": 0.075, "currency": "NOK"}, | ||
| "adId": "adn-id-1559784094", | ||
| "creativeWidth": "980", | ||
| "creativeHeight": "240", | ||
| "creativeId": "jn9hpzvlsf8cpdmm", | ||
| "lineItemId": "q7y9qm5b0xt9htrv" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "expectedBidResponses": [ | ||
| { | ||
| "bids": [ | ||
| { | ||
| "bid": { | ||
| "id": "adn-id-1559784094", | ||
| "impid": "test-imp-id", | ||
| "price": 75, | ||
| "adm": "<ADCODE>", | ||
| "adid": "adn-id-1559784094", | ||
| "adomain": [ | ||
| "google.com" | ||
| ], | ||
| "cid": "q7y9qm5b0xt9htrv", | ||
| "crid": "jn9hpzvlsf8cpdmm", | ||
| "w": 980, | ||
| "h": 240 | ||
| }, | ||
| "type": "banner" | ||
| } | ||
| ], | ||
| "currency": "NOK" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,5 @@ type ImpExtAdnunitus struct { | |
| Network string `json:"network"` | ||
| NoCookies bool `json:"noCookies"` | ||
| MaxDeals int `json:"maxDeals"` | ||
| PriceType string `json:"priceType,omitempty"` | ||
|
There was a problem hiding this comment. should also update @mikael-lundin bidder params is also missing entry for There was a problem hiding this comment. update params tests to add valid and invalid tests for |
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikael-lundin could you help to understand how values are set to
NetBid.CurrencyandGrossBid.Currency. If these vars are not in use then can should remove themThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are always returned from the ad-server so they will always be included in the response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But yeah you are right they can be removed. :)