New Adapter: TradPlus #3987

tradplus · 2024-10-16T10:39:04Z

TradPlus is a leading, stable, and reliable ad monetization platform that is committed to providing global developers with fair, transparent and efficient monetization solutions. We also provide ADX and Saas ADX services. We serve 2,000+ global developers. Moreover, Our SDK has been certified by IAB Tech Lab and also joins Google Play SDK Index. And we have Information Security Management Certification.

Our advertising business spans the world. This is our official website: https://tradplusad.com/en. You can get more details about TradPlus.

this is TradPlus adapter version 1.0.

Thank!

Note: TradPlus only looks at the ext for the first impression and ignored the rest.

github-actions · 2024-10-18T09:27:29Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, ef7a58c

tradplus

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:33:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:41:	makeRequest		81.2%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:76:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:100:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:108:	transform		88.2%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:134:	MakeBids		88.2%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:165:	getMediaTypeForBid	80.0%
total:									(statements)		89.2%

github-actions · 2024-10-24T03:54:44Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, f84c5da

tradplus

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:33:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:41:	makeRequest		81.2%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:76:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:100:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:108:	transform		88.2%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:134:	MakeBids		88.2%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:165:	getMediaTypeForBid	80.0%
total:									(statements)		89.2%

adapters/tradplus/params_test.go

adapters/tradplus/tradplus.go

adapters/tradplus/tradplustest/exemplary/simple-native-1.1.json

SyntaxNode · 2024-10-24T16:53:25Z

adapters/tradplus/tradplus.go

+
+func (a *adapter) makeRequest(request *openrtb2.BidRequest) (*adapters.RequestData, []error) {
+
+	tradplusExt, err := getImpressionExt(&request.Imp[0])


Please link to your prebid.github.io PR and make it clear in that PR that the TradPlus only looks at the ext for the first impression and ignored the rest. Some other adapters do it, but its not a publisher expected behavior.

ok，I've added to the first comment if anything else is needed ?

Yes. New adapters must also open a PR against the Prebid Docs repository here: https://github.com/prebid/prebid.github.io/

Please see the User Documentation section of our new adapter developer guide.

github-actions · 2024-10-25T07:20:21Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 07fb322

tradplus

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:33:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:41:	makeRequest		84.6%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:71:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:95:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:104:	MakeBids		88.2%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:135:	getMediaTypeForBid	80.0%
total:									(statements)		90.7%

tradplus · 2024-10-28T09:18:43Z

@SyntaxNode , hi, I have changed these codes，please review these codes.

github-actions · 2024-10-29T01:51:32Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, d767cf6

tradplus

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:33:	MakeRequests		100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:41:	makeRequest		84.6%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:71:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:95:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:104:	MakeBids		88.2%
github.com/prebid/prebid-server/v2/adapters/tradplus/tradplus.go:135:	getMediaTypeForBid	80.0%
total:									(statements)		90.7%

github-actions · 2024-11-01T03:16:54Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 7c24dd3

tradplus

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:34:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:42:	makeRequest		84.6%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:72:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:96:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:105:	MakeBids		88.2%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:136:	getMediaTypeForBid	80.0%
total:									(statements)		90.7%

tradplus · 2024-11-01T03:34:42Z

@SyntaxNode I re-merged from master.

github-actions · 2024-11-06T09:35:22Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, f177dff

tradplus

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:34:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:42:	makeRequest		84.6%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:72:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:96:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:105:	MakeBids		88.2%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:136:	getMediaTypeForBid	80.0%
total:									(statements)		90.7%

github-actions · 2024-11-14T06:43:13Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 820707d

tradplus

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:34:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:42:	makeRequest		84.6%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:72:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:96:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:105:	MakeBids		88.2%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:136:	getMediaTypeForBid	80.0%
total:									(statements)		90.7%

github-actions · 2024-11-22T01:51:12Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 5629eb1

tradplus

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:34:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:42:	makeRequest		84.6%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:72:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:96:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:105:	MakeBids		88.2%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:136:	getMediaTypeForBid	80.0%
total:									(statements)		90.7%

github-actions · 2024-11-27T07:30:57Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, d5aefa7

tradplus

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:34:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:42:	makeRequest		84.6%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:72:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:96:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:105:	MakeBids		88.2%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:136:	getMediaTypeForBid	80.0%
total:									(statements)		90.7%

github-actions · 2024-12-12T02:30:20Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 4193962

tradplus

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:34:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:42:	makeRequest		84.6%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:72:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:96:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:105:	MakeBids		88.2%
github.com/prebid/prebid-server/v3/adapters/tradplus/tradplus.go:136:	getMediaTypeForBid	80.0%
total:									(statements)		90.7%

tradplus added 4 commits August 2, 2024 14:42

New Adapter: TradPlus

5d43c55

feat: delete validateTradPlusExt

3d6343e

Merge branch 'prebid:master' into tradplus

34c52c0

Merge branch 'prebid:master' into tradplus

4ca9543

tradplus mentioned this pull request Oct 16, 2024

New Adapter: TradPlus #3838

Closed

feat: change getImpressionExt code

ef7a58c

feat: gofmt result modify

f84c5da

SyntaxNode reviewed Oct 24, 2024

View reviewed changes

SyntaxNode self-assigned this Oct 24, 2024

feat: remove function transform and change some code by reviewer comment

07fb322

tradplus requested a review from SyntaxNode October 28, 2024 09:29

Merge branch 'prebid:master' into tradplus

d767cf6

Merge branch 'prebid:master' into tradplus

7c24dd3

Merge branch 'prebid:master' into tradplus

f177dff

Merge branch 'prebid:master' into tradplus

820707d

Merge branch 'prebid:master' into tradplus

5629eb1

Merge branch 'prebid:master' into tradplus

d5aefa7

Merge branch 'prebid:master' into tradplus

4193962

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Adapter: TradPlus #3987

New Adapter: TradPlus #3987

tradplus commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 18, 2024

github-actions bot commented Oct 24, 2024

SyntaxNode Oct 24, 2024

tradplus Oct 25, 2024 •

edited

Loading

SyntaxNode Oct 31, 2024

github-actions bot commented Oct 25, 2024

tradplus commented Oct 28, 2024 •

edited

Loading

github-actions bot commented Oct 29, 2024

github-actions bot commented Nov 1, 2024

tradplus commented Nov 1, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Nov 22, 2024

github-actions bot commented Nov 27, 2024

github-actions bot commented Dec 12, 2024


		func (a adapter) makeRequest(request openrtb2.BidRequest) (*adapters.RequestData, []error) {

		tradplusExt, err := getImpressionExt(&request.Imp[0])

New Adapter: TradPlus #3987

Are you sure you want to change the base?

New Adapter: TradPlus #3987

Conversation

tradplus commented Oct 16, 2024 • edited Loading

github-actions bot commented Oct 18, 2024

Code coverage summary

tradplus

github-actions bot commented Oct 24, 2024

Code coverage summary

tradplus

SyntaxNode Oct 24, 2024

Choose a reason for hiding this comment

tradplus Oct 25, 2024 • edited Loading

Choose a reason for hiding this comment

SyntaxNode Oct 31, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 25, 2024

Code coverage summary

tradplus

tradplus commented Oct 28, 2024 • edited Loading

github-actions bot commented Oct 29, 2024

Code coverage summary

tradplus

github-actions bot commented Nov 1, 2024

Code coverage summary

tradplus

tradplus commented Nov 1, 2024

github-actions bot commented Nov 6, 2024

Code coverage summary

tradplus

github-actions bot commented Nov 14, 2024

Code coverage summary

tradplus

github-actions bot commented Nov 22, 2024

Code coverage summary

tradplus

github-actions bot commented Nov 27, 2024

Code coverage summary

tradplus

github-actions bot commented Dec 12, 2024

Code coverage summary

tradplus

tradplus commented Oct 16, 2024 •

edited

Loading

tradplus Oct 25, 2024 •

edited

Loading

tradplus commented Oct 28, 2024 •

edited

Loading