Smarthub: Update to Attekmi Endpoint #4047

SmartHubSolutions · 2024-11-10T18:26:48Z

We change adapter name from Smarthub to Attekmi,
changing endpoints but keep biddercode 'smarthub'

Docs PR prebid/prebid.github.io#5699

github-actions · 2024-11-10T18:27:35Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, fbd042c

smarthub

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:30:	Builder			80.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:43:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:61:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:70:	MakeRequests		86.7%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:107:	MakeBids		96.4%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:183:	getBidType		100.0%
total:									(statements)		93.1%

github-actions · 2024-11-10T19:33:05Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 427eb60

smarthub

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:30:	Builder			80.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:43:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:61:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:70:	MakeRequests		86.7%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:107:	MakeBids		96.4%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:183:	getBidType		100.0%
total:									(statements)		93.1%

bretg · 2024-11-15T16:03:47Z

We discussed this in committee. Renaming an adapter is covered in the FAQ -- https://docs.prebid.org/faq/prebid-server-faq.html#how-can-we-rename-our-bid-adapter

Please add attekmi as an alias of smarthub. It's confusing for publishers to navigate re-brandings without a transition period where both old and new names are available.

SmartHubSolutions · 2024-11-18T08:18:34Z

Attekmi cannot work as an alias, does that mean we have to create a completely new adapter like Smarthub?
In this case, we will be forced to change all aliases associated with Smarthub

bretg · 2024-11-18T14:10:18Z

Attekmi cannot work as an alias

It certainly could if you wanted it to.

You started this thread with "We change adapter name from Smarthub to Attekmi". Maybe we should step back and confirm what you're actually doing here. This PR just changes the URLs and the titles, but doesn't actually attempt to get rid of the 'smarthub' biddercode.

Let's make sure we're on the same page about what's important, which is that all of your publisher customers have coded their pages/stored requests with the 'smarthub' biddercode. They've also set up build processes that include and enable the 'smarthub' adapter. What Prebid is picky about is forcing publishers to change either their pages or their build processes outside of a major release. That's called a 'breaking change'.

So question - are you going to be asking your customers to change their pages to replace 'smarthub' with 'attekmi'? That's most rebranders want to do, which is why we ask for aliases. This way, you can start transitioning publishers to the new brand but nothing breaks for those who are too busy to change.

If you're just changing the technical DNS endpoints, then there would be no need to change the branding in some of these files. The docs PR covering this suggests that attekmi is intended to be used a biddercode.

Some rebranders don't worry about changing the biddercodes. For instance, the companies 'rubicon' and 'appnexus' haven't existed for many years, but that's still what the bid adapters are called. The fact that 'Magnite' and 'Microsoft' own these biddercodes is mentioned in the documentation, but there's no separate docs files for them.

SmartHubSolutions · 2024-11-20T08:39:09Z

Thanks for the detailed answer!

In this PR we only change the URLs and titles and leave the 'smarthub' biddercode.

Our clients use and will continue to use the 'smarthub' biddercode.

We are not going to ask our clients to change the current biddercode.

We are aware of the experience of other partners, thank you for the clarification.

adapters/smarthub/smarthub_test.go

static/bidder-info/smarthub.yaml

static/bidder-params/smarthub.json

github-actions · 2024-11-24T20:52:00Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, eb11895

smarthub

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:30:	Builder			80.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:43:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:61:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:70:	MakeRequests		86.7%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:107:	MakeBids		96.4%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:183:	getBidType		100.0%
total:									(statements)		93.1%

bretg

I am asking you to have a transition period where people can get used to your rebranding... at least through a major release. i.e. publishers and host companies should not have to be aware of this rebranding for things to work or to find documentation. I view this as no different than appnexus/MicroSoft and rubicon/Magnite.

bretg · 2024-12-05T18:02:52Z

static/bidder-params/smarthub.json

@@ -1,12 +1,12 @@
 {
  "$schema": "http://json-schema.org/draft-04/schema#",
-  "title": "SmartHub Adapter Params",
-  "description": "A schema which validates params accepted by the SmartHub adapter",
+  "title": "Attekmi Adapter Params",


Suggested change

"title": "Attekmi Adapter Params",

"title": "Attekmi (formerly SmartHub) Adapter Params",

I changed title

bretg · 2024-12-05T18:03:07Z

static/bidder-params/smarthub.json

-  "title": "SmartHub Adapter Params",
-  "description": "A schema which validates params accepted by the SmartHub adapter",
+  "title": "Attekmi Adapter Params",
+  "description": "A schema which validates params accepted by the Attekmi adapter",


Suggested change

"description": "A schema which validates params accepted by the Attekmi adapter",

"description": "A schema which validates params accepted by the Attekmi (formerly SmartHub) adapter",

I changed description

bretg · 2024-12-05T18:03:23Z

static/bidder-params/smarthub.json

  "type": "object",
  "properties": {
    "partnerName": {
      "type": "string",
-      "description": "SmartHub unique partner name",
+      "description": "Attekmi unique partner name",


Suggested change

"description": "Attekmi unique partner name",

"description": "Attekmi (formerly SmartHub) unique partner name",

No problem. I changed description

github-actions · 2024-12-09T18:54:11Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, a85617e

smarthub

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:30:	Builder			80.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:43:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:61:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:70:	MakeRequests		86.7%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:107:	MakeBids		96.4%
github.com/prebid/prebid-server/v3/adapters/smarthub/smarthub.go:183:	getBidType		100.0%
total:									(statements)		93.1%

Smarthub: renaming Smarthub to Attekmi

fbd042c

SmartHubSolutions mentioned this pull request Nov 10, 2024

Smarthub: renaming Smarthub to Attekmi prebid/prebid.github.io#5699

Open

2 tasks

fix https links

427eb60

ChrisHuie self-requested a review November 12, 2024 18:47

ChrisHuie self-assigned this Nov 12, 2024

ChrisHuie removed their request for review November 15, 2024 15:51

ChrisHuie removed their assignment Nov 15, 2024

bsardo self-assigned this Nov 22, 2024

bsardo changed the title ~~Smarthub: renaming Smarthub to Attekmi~~ Smarthub: Update to Attekmi Endpoint Nov 22, 2024

bsardo reviewed Nov 22, 2024

View reviewed changes

adapters/smarthub/smarthub_test.go Outdated Show resolved Hide resolved

static/bidder-info/smarthub.yaml Show resolved Hide resolved

static/bidder-info/smarthub.yaml Show resolved Hide resolved

static/bidder-params/smarthub.json Outdated Show resolved Hide resolved

update test endpoints

eb11895

bsardo assigned przemkaczmarek Nov 26, 2024

przemkaczmarek previously approved these changes Nov 26, 2024

View reviewed changes

bretg requested changes Dec 5, 2024

View reviewed changes

update title and description

a85617e

SmartHubSolutions dismissed przemkaczmarek’s stale review via a85617e December 9, 2024 18:53

przemkaczmarek approved these changes Dec 12, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Smarthub: Update to Attekmi Endpoint #4047

Smarthub: Update to Attekmi Endpoint #4047

SmartHubSolutions commented Nov 10, 2024

github-actions bot commented Nov 10, 2024

github-actions bot commented Nov 10, 2024

bretg commented Nov 15, 2024

SmartHubSolutions commented Nov 18, 2024 •

edited

Loading

bretg commented Nov 18, 2024

SmartHubSolutions commented Nov 20, 2024

github-actions bot commented Nov 24, 2024

bretg left a comment

bretg Dec 5, 2024

SmartHubSolutions Dec 9, 2024

bretg Dec 5, 2024

SmartHubSolutions Dec 9, 2024

bretg Dec 5, 2024

SmartHubSolutions Dec 9, 2024

github-actions bot commented Dec 9, 2024

	"title": "Attekmi Adapter Params",
	"title": "Attekmi (formerly SmartHub) Adapter Params",

	"description": "A schema which validates params accepted by the Attekmi adapter",
	"description": "A schema which validates params accepted by the Attekmi (formerly SmartHub) adapter",

	"description": "Attekmi unique partner name",
	"description": "Attekmi (formerly SmartHub) unique partner name",

Smarthub: Update to Attekmi Endpoint #4047

Are you sure you want to change the base?

Smarthub: Update to Attekmi Endpoint #4047

Conversation

SmartHubSolutions commented Nov 10, 2024

github-actions bot commented Nov 10, 2024

Code coverage summary

smarthub

github-actions bot commented Nov 10, 2024

Code coverage summary

smarthub

bretg commented Nov 15, 2024

SmartHubSolutions commented Nov 18, 2024 • edited Loading

bretg commented Nov 18, 2024

SmartHubSolutions commented Nov 20, 2024

github-actions bot commented Nov 24, 2024

Code coverage summary

smarthub

bretg left a comment

Choose a reason for hiding this comment

bretg Dec 5, 2024

Choose a reason for hiding this comment

SmartHubSolutions Dec 9, 2024

Choose a reason for hiding this comment

bretg Dec 5, 2024

Choose a reason for hiding this comment

SmartHubSolutions Dec 9, 2024

Choose a reason for hiding this comment

bretg Dec 5, 2024

Choose a reason for hiding this comment

SmartHubSolutions Dec 9, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 9, 2024

Code coverage summary

smarthub

SmartHubSolutions commented Nov 18, 2024 •

edited

Loading