Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarthub: renaming Smarthub to Attekmi #5699

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SmartHubSolutions
Copy link
Contributor

@SmartHubSolutions SmartHubSolutions commented Nov 10, 2024

🏷 Type of documentation

  • text edit only (wording, typos)

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself

We change the name from Smarthub to Attekmi but leave the biddercode 'smarthub'

Prebid.js PR prebid/Prebid.js#12432
Prebid-server PR prebid/prebid-server#4047

Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 099cc6f
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/673af6f6e6265000081d4ab9
😎 Deploy Preview https://deploy-preview-5699--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also submit attekmi.md in this pr similar to this: https://github.com/prebid/prebid.github.io/pull/5704/files which documents a new alias

this means people will find your documentation no matter which name they look for and both names will appear on the download page

@bretg
Copy link
Contributor

bretg commented Nov 15, 2024

I agree with Patrick here. Renaming adapters is common, but can be confusing to publishers who can't find documentation for the name they're familiar with. The smarthub.md file can say "please note that SmartHub has been renamed to Attekmi" or something like that.

@SmartHubSolutions
Copy link
Contributor Author

I added attekmi.md and add note about rebranding in smarthub.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants