Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adform.md docs updated #2262

Merged
merged 2 commits into from
Aug 26, 2020
Merged

adform.md docs updated #2262

merged 2 commits into from
Aug 26, 2020

Conversation

braizhas
Copy link
Contributor

No description provided.

braizhas added a commit to adform/prebid-server that referenced this pull request Aug 21, 2020
| `mkv` | optional | Comma-separated key-value pairs | `'city:NY'` | `string` |
| `mkw` | optional | Comma-separated keywords | `'news,sport'` | `string` |
| `minp` | optional | Minimum CPM price | `2.55` | `number` |
| `cdims` | optional | Comma-separated creative dimentions | `'300x250'` | `string` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation does not allow for spaces to exist between in the CSV list, such like 300x250, 1x1. Can you please make that clear in this doc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the right place for such a note? c6b1f06

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so? @bretg does this look good to you?

@bretg bretg merged commit 22f7e7e into prebid:master Aug 26, 2020
sbrosinski added a commit to smaato/prebid.github.io that referenced this pull request Aug 31, 2020
* origin/master: (402 commits)
  Updates for CMP Functionality Best Practices (prebid#2284)
  cross-linking TCF/CMP docs (prebid#2283)
  Restored zoneId parameter in criteo bid adapter doc (prebid#2275)
  Add sspBC adapter  (prebid#2157)
  Update cmp-best-practices.md
  Update cmp-best-practices.md
  Add supported modules table for GDPR Enforcement module. (prebid#2271)
  New Adapter: Concert (prebid#2033)
  ID+ submodule (prebid#2260)
  Cmp best practices (prebid#2282)
  creative declaration
  fixing creative pages, adding GAM declaration (prebid#2281)
  adding gvl_id to metadata (prebid#2279)
  removed syntax.css (prebid#2278)
  updated the PBM mobile privacy page (prebid#2250)
  Added TCF v2.0 support to the documentation (prebid#2276)
  Add smartx.md markdown for docs (prebid#2272)
  1.Change ironsource to be lower case all over (prebid#2265)
  Update show-outstream-video-ads.md for backupOnly renderers (prebid#2259)
  adform.md docs updated (prebid#2262)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants