Add smartx.md markdown for docs #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
muuki88
requested changes
Aug 25, 2020
dev-docs/bidders/smartx.md
Outdated
| --- | ||
| layout: bidder | ||
| title: smartx | ||
| description: Prebid smartx Bidder Adaptor |
There was a problem hiding this comment.
Can it be that both of us are wrong?
https://github.com/prebid/Prebid.js/tree/master/modules
All modules here are named with "e" in Adapter.
There was a problem hiding this comment.
Indeed 😂 Mixing german and english makes my english so much worst 😬
dev-docs/bidders/smartx.md
Outdated
| | `siteId` | required | A unique SiteID. | `'site_id'` | `string` | | ||
| | `bidfloor` | required | Value of Bidfloor. | `0.3` | `float` | | ||
| | `bidfloorcur` | required | Used Currency. (e.g. EUR, USD etc.) | `'EUR'` | `string` | | ||
| | `context` | required | Token that describes which context to play: 'instream' or 'outstream' | `'outstream'` | `string` | |
There was a problem hiding this comment.
It's not required as far as I can see in the implementation. Maybe this can be removed completely and only the mediaType.video.context parameter is being used.
dev-docs/bidders/smartx.md
Outdated
| | `bidfloorcur` | required | Used Currency. (e.g. EUR, USD etc.) | `'EUR'` | `string` | | ||
| | `context` | required | Token that describes which context to play: 'instream' or 'outstream' | `'outstream'` | `string` | | ||
| | `outstream_function` | optional | Custom function to be used as a renderer. | `function(bid){console.log(bid);}` | `function` | | ||
| | `outstream_options` | optional | Object to set options on the smartx renderer. | `{}` | `object` | |
There was a problem hiding this comment.
These are required for context outstream.
There was a problem hiding this comment.
Changed to required with further description
muuki88
approved these changes
Aug 26, 2020
sbrosinski
added a commit
to smaato/prebid.github.io
that referenced
this pull request
Aug 31, 2020
* origin/master: (402 commits) Updates for CMP Functionality Best Practices (prebid#2284) cross-linking TCF/CMP docs (prebid#2283) Restored zoneId parameter in criteo bid adapter doc (prebid#2275) Add sspBC adapter (prebid#2157) Update cmp-best-practices.md Update cmp-best-practices.md Add supported modules table for GDPR Enforcement module. (prebid#2271) New Adapter: Concert (prebid#2033) ID+ submodule (prebid#2260) Cmp best practices (prebid#2282) creative declaration fixing creative pages, adding GAM declaration (prebid#2281) adding gvl_id to metadata (prebid#2279) removed syntax.css (prebid#2278) updated the PBM mobile privacy page (prebid#2250) Added TCF v2.0 support to the documentation (prebid#2276) Add smartx.md markdown for docs (prebid#2272) 1.Change ironsource to be lower case all over (prebid#2265) Update show-outstream-video-ads.md for backupOnly renderers (prebid#2259) adform.md docs updated (prebid#2262) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation for smartx bid adapter.