No bid support for duration alias #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dev-docs/bidders/nobidBidAdapter.md
8 tasks
bretg
requested changes
Jul 15, 2021
|
Hello @bretg , |
patmmccann
requested changes
Jul 19, 2021
| schain_supported: true | ||
| coppa_supported: true | ||
| userId: criteo, unifiedId, id5Id | ||
| safeframes_ok: true |
There was a problem hiding this comment.
please indicate false as per your comments below
There was a problem hiding this comment.
@patmmccann
I don't understand your request. Why would I change these parameters?
There was a problem hiding this comment.
@redaguermas - he's suggesting that your statement below "it is highly recommended to make sure the “Serve in Safeframe” box in creative settings is unchecked" makes it sound like you don't actually support safeframes, so safeframes_ok should be false. But @patmmccann , they do also then say "If you absolutely want to run...", so perhaps they do support it somewhat grudgingly.
not sure it matters, but playing it safe
bretg
approved these changes
Jul 21, 2021
|
will be part of PBJS 5.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Duration Media Prebid adapter.