Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nobid Bid Adapter: add support for alias duration #7177

Merged
merged 23 commits into from
Jul 20, 2021

Conversation

redaguermas
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Added support for alias "duration".

  • test parameters for validating bids
{
  bidder: 'duration',
  params: {
    // ...
  }
}

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

redaguermas and others added 16 commits March 4, 2020 15:39
* 'master' of https://github.com/prebid/Prebid.js: (49 commits)
  Submitting Clicktripz bid adapter (prebid#4929)
  add UNICORN bid adapter (prebid#4917)
  3.12.0-pre
  3.11.0 release
  Eids liveintent ext fix (prebid#4944)
  add mediaforce bid adapter (prebid#4933)
  update logic in adpod module for playersize (prebid#4953)
  Module - Size Mapping V2 (prebid#4690)
  Lifestreet adapter 3.0 (prebid#4927)
  IX Adapter - Increase banner TTL to 300s (prebid#4957)
  assert string returned not that we break things (prebid#4962)
  added option to url parser to ignore decoding entire url (prebid#4938)
  adding user-id support in medianet adapter (prebid#4925)
  removing the log (prebid#4960)
  add import extensions (prebid#4959)
  Add 7xbid adapter to compatible with prebid 3.0 (prebid#4908)
  Fix failing code-coverage command (prebid#4892)
  enable no-console eslint rule for project (prebid#4802)
  update audigent tests to fix larger test suite issue (prebid#4952)
  use bidId or bidIds in the payload (prebid#4903)
  ...
* 'master' of https://github.com/prebid/Prebid.js: (102 commits)
  Marsmedia - Add vastXml and fix id response (prebid#5067)
  PubMatic adapter to support image sync (prebid#5104)
  minor consentManagement fix (prebid#5050)
  fix circle ci failing tests (prebid#5113)
  Add Relaido Adapter (prebid#5101)
  Add new bid adapter for ConnectAd (prebid#4806)
  change payload (prebid#5105)
  Utils updates (prebid#5092)
  Read OpenRTB app objects if set in config + bug fix for when ad units are reloaded (prebid#5086)
  Criteo : added first party data mapping to bidder request (prebid#4954)
  updateAdGenerationManual (prebid#5032)
  New bid adapter: Wipes (prebid#5051)
  Prebid manager analytics utm tags (prebid#4998)
  CRITEO RTUS Integration with Yieldmo Prebid (prebid#5075)
  isSafariBrowser update  (prebid#5077)
  Support min &max duration for onevideo (prebid#5079)
  increment pre version
  Prebid 3.15.0 release
  prebid#5011 Fix to set Secure attribute on cookie when SameSite=none (prebid#5064)
  Prebid adapter for windtalker (prebid#5040)
  ...
# Conflicts:
#	test/spec/modules/nobidBidAdapter_spec.js
@redaguermas
Copy link
Contributor Author

Hello,
Can you please review this PR. The error in the CircleCI is unrelated to my code.

@ChrisHuie ChrisHuie self-requested a review July 14, 2021 07:28
@ChrisHuie ChrisHuie self-assigned this Jul 14, 2021
@ChrisHuie
Copy link
Collaborator

ChrisHuie commented Jul 14, 2021

@redaguermas rerean tests and passed but looks like you uploaded several of your ide files with this pr and your package-lock file. Can you please remove all those files and maybe add a test case for the new state added

@ChrisHuie ChrisHuie changed the title No bid version 1.3.1 Nobid Bid Adapter: add support for alias duration Jul 14, 2021
@robertrmartinez
Copy link
Collaborator

@redaguermas Yeah please remove all of your extra files.

Should just be only two files, the bid adapter, and the associated _spec file testing the change.

package-lock should not be in there either.

Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also remove nobidBidAdapter.js.orig and the changes to package-lock.json

modules/nobidBidAdapter.js Outdated Show resolved Hide resolved
a Outdated Show resolved Hide resolved
@redaguermas
Copy link
Contributor Author

Hello @bretg ,
Thank you for the feedback. Can you please review the latest changes.
-Regards

@ChrisHuie ChrisHuie merged commit 9a91886 into prebid:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants