Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loglylift adapter #3429

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Loglylift adapter #3429

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53591d2
add description for loglylift bid adapter
HashimotoLogly Nov 15, 2021
4f51495
use real adspot which has actual test ad
HashimotoLogly Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions dev-docs/bidders/loglylift.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
---
layout: bidder
title: LOGLY lift
description: Prebid LOGLY lift Bidder Adaptor
biddercode: loglylift
gdpr_supported: false
usp_supported: false
coppa_supported: false
schain_supported: false
dchain_supported: false
media_types: no-display, native
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if no-display is required here. Only native should be sufficient. @bretg any objections?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they don't support display, then yes, "no-display" is appropriate. This is because the default metadata table in pbs-bidders.md assumes everyone supports display. This was easier than trying to get answers for 300 bidders about what media types they supported.

Copy link
Contributor Author

@HashimotoLogly HashimotoLogly Dec 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bretg
Hello.
Is this still under discussion?

Our adapter is designed to support only native format. And I just follow this example.
Banners_and_Alerts_と_How_to_Add_a_New_Prebid_js_Bidder_Adapter_for_Header_Bidding

In what case, should "display" be noted as supported media_types? What "display" exactly means?

safeframes_ok: false
deals_supported: false
floors_supported: false
fpd_supported: false
pbjs: true
pbs: false
prebid_member: false
---


### Bid Params

{: .table .table-bordered .table-striped }
| Name | Scope | Description | Example | Type |
|--------|----------|----------------------------------------------------------|----------|-----------|
| `adspotId` | required | adspot id managed by LOGLY lift | `4302078` | `integer` |