Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Travis for Linux, Mac and Windows #24

Merged
merged 5 commits into from
Jan 25, 2019
Merged

Enable Travis for Linux, Mac and Windows #24

merged 5 commits into from
Jan 25, 2019

Conversation

ralphtheninja
Copy link
Member

@ralphtheninja ralphtheninja commented Jan 23, 2019

Closes #23

Squash at merge.

@ralphtheninja
Copy link
Member Author

Hmm interesting. It fails on windows + node 6:

C:\Users\travis\build\prebuild\prebuildify\test\package>if not defined npm_config_node_gyp (node "C:\ProgramData\nvs\node\6.16.0\x64\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild --target=v6.16.0 --target_arch=x64 --release )  else (node "" rebuild --target=v6.16.0 --target_arch=x64 --release ) 
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
MSBUILD : error MSB4132: The tools version "2.0" is unrecognized. Available tools versions are "4.0".

@ralphtheninja
Copy link
Member Author

Possibly related chjj/pty.js#60

@ralphtheninja
Copy link
Member Author

@emilbayes Have you seen any similar issues with e.g. sodium-native?

@emilbayes
Copy link
Contributor

@ralphtheninja Yep check this out: https://github.com/sodium-friends/sodium-native/blob/master/preinstall.js#L62-L92

Was contributed by @enko

@ralphtheninja
Copy link
Member Author

Oh ffs

$ if [[ "$TRAVIS_OS_NAME" == "windows" ]]; then npm i --global --production windows-build-tools; fi
> windows-build-tools@5.1.0 postinstall C:\ProgramData\nvs\node\6.16.0\x64\node_modules\windows-build-tools
> node ./dist/index.js
C:\ProgramData\nvs\node\6.16.0\x64\node_modules\windows-build-tools\dist\aquire-installers.js:15
async function aquireInstallers(cb) {
      ^^^^^^^^
SyntaxError: Unexpected token function
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:549:28)
    at Object.Module._extensions..js (module.js:586:10)
    at Module.load (module.js:494:32)
    at tryModuleLoad (module.js:453:12)
    at Function.Module._load (module.js:445:3)
    at Module.require (module.js:504:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (C:\ProgramData\nvs\node\6.16.0\x64\node_modules\windows-build-tools\dist\start.js:4:29)

@vweevers
Copy link
Member

FWIW a --msvs_version flag would have been enough I think to fix node 6. The npm install -g windows-build-tools is becoming the preferred answer for many windows build problems but it's a bit of a sledgehammer if you already have a build environment.

Anyway, +1 to dropping node 6!

@ralphtheninja ralphtheninja merged commit d961d38 into master Jan 25, 2019
@ralphtheninja ralphtheninja deleted the travis branch January 25, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants