Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Travis for Linux, Mac and Windows #24

Merged
merged 5 commits into from
Jan 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
language: node_js

os:
- osx
- windows
- linux

node_js:
- 8
- 10
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
# prebuildify

Create and package prebuilds for native modules
> Create and package prebuilds for native modules

```
npm install -g prebuildify
```

[![Build Status](https://travis-ci.org/prebuild/prebuildify.svg?branch=master)](https://travis-ci.org/prebuild/prebuildify)

## Usage

First go to your native module and make a bunch of prebuilds
Expand Down
2 changes: 1 addition & 1 deletion bin.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (argv.all) {
if (argv.napi && targets.length === 0) {
targets = [
abi.supportedTargets.filter(onlyNode).pop(),
abi.supportedTargets.filter(onlyElectron).pop(),
abi.supportedTargets.filter(onlyElectron).pop()
]

if (targets[0].target === '9.0.0') targets[0].target = '9.6.1'
Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ function strip (file, opts, cb) {

var args = opts.platform === 'darwin' ? [file, '-Sx'] : [file, '--strip-all']
var stripBin = process.env.STRIP || 'strip'
var child = proc.spawn(stripBin, args, { stdio: 'ignore'})
var child = proc.spawn(stripBin, args, {stdio: 'ignore'})

child.on('exit', function (code) {
if (code) return cb(spawnError('strip', code))
Expand Down