Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support display selected values instead of "n selected" in multiple selection mode #69

Closed
vincentcn opened this issue Jan 16, 2018 · 3 comments
Closed

Support display selected values instead of "n selected" in multiple selection mode #69

vincentcn opened this issue Jan 16, 2018 · 3 comments
Assignees
@arongraham-ge
Labels
enhancement

Comments

@vincentcn
Copy link

vincentcn commented Jan 16, 2018 •
edited
Loading

Support display selected values instead of "n selected" in multiple selection mode

Hi,

Currently px-dropdown component display "n selected" in multiple selection mode
screen shot 2018-01-16 at 5 29 24 pm

Users have to make one click to view current selected values when px-dropdown is used as an input in a form. It is not good user experience.
Could you please help to support display selected values like this:
dropdownwithdisplayvalue
@vincentcn vincentcn changed the title Display selected values instead of "n selected" in multiple selection mode Support display selected values instead of "n selected" in multiple selection mode Jan 16, 2018
@randyaskin
Copy link
Contributor

The comma-separated list was how the functionality was originally implemented in Piotrek's pull request, but it's not scalable from a usability perspective: #32 (comment)

@vincentcn
Copy link
Author

A dropdown component does not have many selections in most cases. How about make it configurable, display "n selected" or comma separated list can be configured by a flag?

@arongraham-ge arongraham-ge self-assigned this Jan 1, 2019
arongraham-ge added a commit that referenced this issue Jan 4, 2019
@arongraham-ge
Merge pull request #94 from predixdesignsystem/make-display-value-cou…
cc42fe7 
…nt-a-variable-#69

Make display value count a variable as described in issue #69
@arongraham-ge
Copy link
Contributor

@vincentcn this has been added in release v4.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arongraham-ge arongraham-ge

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vincentcn @randyaskin @mdwragg @arongraham-ge