Re add styles that was removed #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those styles should not have been removed in the first place
|
@joshsylvester @mallik Please help review |
|
|
|
If we add back these styles, we could close this PR, the item icon's margin-right value will be back. |
|
@benjaminliugang this PR, adds back a style that was removed so some trumps spacing styles were removed that, removes padding for px-dropdown of a certain style. BUt that PR https://github.com/predixdesignsystem/px-dropdown/pull/104/files is a different issue, its for RTL spacing so we need both |
joshsylvester
approved these changes
Mar 4, 2019
|
I am closing this PR since #104 has both combined |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styles were removed in this PR
This was causing regression in px-dropdown padding left when it was used in readOnly mode.