Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace debuggerflavor with debugger (take #2) #1357

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

starkos
Copy link
Member

@starkos starkos commented Oct 21, 2019

What does this PR do?

A replacement for PR #1063 with additional fixes. The original message: "Remove duplicate in APIs as debugger can be used to set DebuggerFlavor in Visual Studio."

Closes #1060.

How does this PR change Premake's behavior?

Deprecates the Visual Studio-specific debuggerflavor() in favor of debugger().

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@starkos starkos merged commit b96bc35 into premake:master Oct 23, 2019
@starkos starkos deleted the deprecate-debuggerflavor branch October 23, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not sure about debugflavour
1 participant