Delete directory does not check children #821
Comments
PhilRunninger
pushed a commit
that referenced
this issue
Apr 2, 2018
Fixes #821. If a node isn't opened in NERDTree, it's children aren't known yet, so when deleting the node (with `m`, `d`), the user isn't properly asked to confirm the delete. It was going to the less strict `Y`/`n` confirmation, instead of the `yes` confirmation for non-empty directories. This change checks to see if the node is opened already. If it is, the existing getChildCount() function is used; otherwise, the disk is read to get the number of children there.
|
@SammysHP, I just created a pull request to fix this. Can you test it out for me? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
You can delete a node via m d and confirm via y. If the node is a directory which has children, you have to type
yesinstead. But this works only if you have opened the directory in nerdtree previously, it does not read the contents by itself automatically. So sometimes y is enough to delete a directory that is not empty.(I would prefer an option to always confirm via y, but that is a different issue.)
The text was updated successfully, but these errors were encountered: