If node isn't open, count children on disk before deleting. #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #821. If a node isn't opened in NERDTree, it's children aren't known yet, so when deleting the node (with `m`, `d`), the user isn't properly asked to confirm the delete. It was going to the less strict `Y`/`n` confirmation, instead of the `yes` confirmation for non-empty directories. This change checks to see if the node is opened already. If it is, the existing getChildCount() function is used; otherwise, the disk is read to get the number of children there.
|
Tested and it works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #821. If a node isn't opened in NERDTree, it's children aren't
known yet, so when deleting the node (with
m,d), the user isn'tproperly asked to confirm the delete. It was going to the less strict
Y/nconfirmation, instead of theyesconfirmation for non-emptydirectories.
This change checks to see if the node is opened already. If it is, the
existing getChildCount() function is used; otherwise, the disk is read
to get the number of children there.