use shared settings #194
use shared settings #194
Conversation
|
The tests break exactly the same way at home with or without the modifications. |
|
I can try and get to it this weekend |
|
Any progress on this? |
- jsx-eslint/eslint-plugin-react#2082 is just the symptom that is causing my editor to add "Warnings" to the top of my .js files. - prettier/prettier-eslint#194 is the actual bug; prettier-eslint isn't passing the `baseConfig` to eslint.
- jsx-eslint/eslint-plugin-react#2082 is just the symptom that is causing my editor to add "Warnings" to the top of my .js files. - prettier/prettier-eslint#194 is the actual bug; prettier-eslint isn't passing the `baseConfig` to eslint.
|
I'd merge this but I don't have write access; @zimme @kentcdodds if you give me GitHub/npm access I'll take care of this |
|
@suchipi Want me to add you to the ESLint team? |
|
Sure |
|
Done ✅ |
|
Thanks guys for taking care of this, sorry for ghosting you on this but recently got a baby so i haven't had any time for any of my regular open-source work. |
|
CONGRATULATIONS @zimme!! |
|
@kentcdodds Thanks 😄 |
|
Congrats @zimme!!! No need to apologize, that is infinitely more important than this! That said... 😅 @kentcdodds maybe you could help me out? Although this has been merged, it hasn't been published to npm yet. Could I get access so I can take care of it? |
|
Hmmm... I haven't been maintaining this project in quite a while. I'm not sure whether @zimme set up automated releases or not. I'll look. |
|
Ah, yes, releases are automated, but the build is busted with a bunch of test errors like:
I'm not sure what's going on there 😖 |
|
Automated releases should be set up, but it seems the tests are failing so it can't publish a new release |
|
Ah, okay. Then I just need to fix the tests. Thanks! |
|
I took a stab at this today but the cause wasn't obvious so I lost interest :/ might try again later but if someone else does it before me, I would not at all be offended |
|
Are we not going to get a release until someone fixes the tests :)? |
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Fix #192