Warning: React version not specified in eslint-plugin-react settings. #1955

kud · 2018-08-22T16:06:57Z

Hello,

Since I've updated this plugin, i've got a message like Warning: React version not specified in eslint-plugin-react settings..

This is true, I didn't specify the version of react, and this happens due to 8738e59#diff-4e51c5c91adee02670adaca34f7fd7fdR17

However, when I read the doc, I've got this:

"version": "15.0", // React version, default to the latest React stable release

It's said "by default, it uses the latest version of react".

So why displaying a warning if there's a default and this is what I want? as I keep my react often upgraded.

The text was updated successfully, but these errors were encountered:

ljharb · 2018-08-22T20:40:58Z

(linking to your comment here: #1857 (comment))

ljharb · 2018-08-22T20:41:59Z

Just because there's a default doesn't mean you shouldn't always be providing an explicit value.

Repeating #1857 (comment):

i could see adding a separate option for "detect" (using the "version" as a fallback), which did require('react').version - want to open a PR that adds that?
(Note that it'd have to use process.cwd(), and the resolve package, to get the proper require path)

kud · 2018-08-22T21:09:33Z

Yes, it's true.

For the moment, I use this workaround: "version": "999.999.999".

chrisdothtml · 2018-08-23T20:32:14Z

+1 for supporting latest as the value

marcofugaro · 2018-08-28T16:44:11Z

Yeah please I don't want to update this config each time a new react comes out

ljharb · 2018-08-28T16:50:01Z

You have to update your package.json every time that happens; I’m not sure also updating eslintrc is much harder.

marcofugaro · 2018-08-28T17:00:10Z

Yeaaah... I don't have it in a package.json, I have it in the eslint config shared for the team, and each time I would have to upgrade deps, update by hand, publish a new version of the tool.

Most importantly, I upgrade my dependencies using yarn upgrade-interactive --latest, not by hand. I (or other mantainers) might forget to update this version by hand.

chrisdothtml · 2018-08-28T17:03:22Z

We also use a shared eslint config and this would make it quite annoying every upgrade. If "latest" isn't supported, everyone's just gonna use "999.999.999" instead, which could lead to issues in the future if this plugin assumes that property contains their actual React version

kud · 2018-08-29T08:14:29Z

#1955 (comment)

Well, I use ncu to update my packages, and yes it's not hard to update .eslintrc but you have to remember this and it's not something I want. :D

I'm using 999.999.999 for the moment.

bhardy · 2018-08-29T23:37:40Z

Comment removed and new issue created: #1963

ljharb · 2018-08-30T00:09:55Z

@bhardy that seems like a different issue; if you have the settings object with a react version you shouldn't get a warning at all.

bhardy · 2018-08-30T00:12:20Z

@ljharb would you like me to create a new issue?

ljharb · 2018-08-30T00:13:17Z

@bhardy yes please :-)

This is the best behavior so people have seamless upgrades to new React majors. This is probably a terrible default and warning from the ESLint plugin, and we need to wait for jsx-eslint/eslint-plugin-react#1955 before changing this hardcoded behavior. Closes facebook#5034

This is the best behavior so people have seamless upgrades to new React majors. This is probably a terrible default warning from the ESLint plugin, and we need to wait for jsx-eslint/eslint-plugin-react#1955 before changing this hardcoded behavior. Closes facebook#5034

mohsinulhaq · 2018-09-22T20:57:21Z

I tried {"version": "latest"}, and it's working fine. Why are we pushing for '999.999.999'?

ljharb · 2018-09-23T01:13:03Z

@mohsinulhaq it would be more explicit than relying on React never hitting v999

mohsinulhaq · 2018-09-23T07:11:42Z

but there is no downside of using latest with regards to linting, right?

ljharb · 2018-09-23T14:58:35Z

The downside would be a lack of explicit configuration with respect to which React version you’re using, i suppose.

This is the best behavior so people have seamless upgrades to new React majors. This is probably a terrible default warning from the ESLint plugin, and we need to wait for jsx-eslint/eslint-plugin-react#1955 before changing this hardcoded behavior. Closes facebook#5034

anilanar · 2018-10-10T09:52:04Z

I think this is an important bug. There are editor plugins that rely on exit code and stdout of eslint --fix/prettier-eslint for auto-formatting.

As a formatter, prettier-eslint must not log something to stdout when exit code is 0.

bertho-zero · 2018-10-10T10:17:12Z

@anilanar Even when the version is filled the warning appears with prettier-eslint, I fixed that and I wait for a response. (prettier/prettier-eslint#194)

…as per jsx-eslint/eslint-plugin-react#1955

samhou1988 · 2021-02-20T06:11:05Z

.eslintrc.js

settings: {
    react: {
        version: 'detect',
    },
}

Fix the warning of React version not speicifed in eslint-plugin-react settings. See also: - jsx-eslint/eslint-plugin-react#1955

daryazata · 2022-06-15T20:16:45Z

Simply need to write exact version of react you re using ..

ljharb · 2022-06-16T02:14:26Z

@daryazata it supports "detect", so you shouldn't have to do that.

MidKnightXI · 2022-09-07T07:49:20Z

For people using .yml instead of .js or .json you just need to add it like that to your .eslintrc.yml

...
settings:
  react:
    version: "detect"

julielouie · 2022-09-22T20:29:49Z

Hi there, I seem to still be having this issue on v7.31.8, and would love some insight if I'm just setting things up incorrectly.
This is a brand new React/TS project being set up using VS Code, so what you see is all I have currently.
The eslint library is being loaded in successfully, and I don't have any errors, but I am still getting this warning:

The contents of my .eslintrc.js:

module.exports = {
  root: true,
  env: {
    node: true,
    browser: true
  },
  parser: '@typescript-eslint/parser',
  parserOptions: {
    ecmaVersion: 2022,
    sourceType: 'module',
    ecmaFeatures: {
      jsx: true
    },
    settings: {
      react: {
        version: 'detect'
      },
      'import/resolver': {
        node: {
          paths: ['src'],
          extensions: ['.js', '.jsx', '.ts', '.tsx']
        }
      }
    }
  },
  extends: [
    'eslint:recommended',
    'plugin:react/recommended',
    'plugin:import/recommended',
    'plugin:import/typescript',
    'plugin:@typescript-eslint/recommended',
    'eslint-config-prettier'
  ],
  rules: {
    'react/react-in-jsx-scope': 'off',
    semi: [2, 'always']
  }
};

The contents of my package.json:

{
  "name": "project",
  "private": true,
  "version": "0.0.0",
  "scripts": {
    "dev": "vite",
    "build": "tsc && vite build",
    "preview": "vite preview",
    "lint": "eslint . --ext .ts,.tsx"
  },
  "dependencies": {
    "react": "^18.2.0",
    "react-dom": "^18.2.0"
  },
  "devDependencies": {
    "@types/react": "^18.0.17",
    "@types/react-dom": "^18.0.6",
    "@typescript-eslint/eslint-plugin": "^5.38.0",
    "@typescript-eslint/parser": "^5.38.0",
    "@vitejs/plugin-react": "^2.1.0",
    "eslint": "^8.23.1",
    "eslint-config-prettier": "^8.5.0",
    "eslint-plugin-import": "^2.26.0",
    "eslint-plugin-react": "^7.31.8",
    "prettier": "^2.7.1",
    "typescript": "^4.6.4",
    "vite": "^3.1.0"
  }
}

Current file structure:

ljharb · 2022-09-22T20:31:05Z

@juliehchung try running eslint on the command line. if it works, then the problem is in your editor; if not, then please file a new issue, ideally with a repro repo.

julielouie · 2022-09-22T21:20:59Z

@juliehchung try running eslint on the command line. if it works, then the problem is in your editor; if not, then please file a new issue, ideally with a repro repo.

Do you mind elaborating what you mean by this? The same warning still pops up when running eslint via the cli, but it will still run without errors.

ljharb · 2022-09-22T21:31:49Z

I mean running npx eslint ., outside of vscode.

If the same warning pops up, then I'd love a new issue with a repro repo :-)

julielouie · 2022-09-22T21:52:29Z

I mean running npx eslint ., outside of vscode.

If the same warning pops up, then I'd love a new issue with a repro repo :-)

Submitted here #3438

- eslint-import-resolver-typescript - eslint-plugin-flowtype - eslint-plugin-import 2. stop eslint from nagging react version not specified jsx-eslint/eslint-plugin-react#1955 (comment) 3. remove redundant eslint config and rules 4. use popular recommended setting for easier config management and modern practices

This is the best behavior so people have seamless upgrades to new React majors. This is probably a terrible default warning from the ESLint plugin, and we need to wait for jsx-eslint/eslint-plugin-react#1955 before changing this hardcoded behavior. Closes facebook#5034

This is the best behavior so people have seamless upgrades to new React majors. This is probably a terrible default warning from the ESLint plugin, and we need to wait for jsx-eslint/eslint-plugin-react#1955 before changing this hardcoded behavior. Closes #5034

ljharb added enhancement help wanted labels Aug 22, 2018

bhardy mentioned this issue Aug 30, 2018

Plugin Usage: Warning: React version not specified in eslint-plugin-react settings. #1963

Closed

alexzherdev mentioned this issue Sep 11, 2018

[New] Support "detect" option for React version setting #1978

Merged

ljharb mentioned this issue Sep 13, 2018

Add property for latest stable React release to be used with React settings #1981

Closed

Timer mentioned this issue Sep 20, 2018

Always lint with latest React version facebook/create-react-app#5043

Merged

ljharb closed this as completed in #1978 Oct 16, 2018

francescozanoni added a commit to francescozanoni/javascript-hodgepodge that referenced this issue Dec 25, 2020

ESLint configutration > React plugin: set React version to 'latest', …

8d6319f

…as per jsx-eslint/eslint-plugin-react#1955

wholemann added a commit to wholemann/react-week1-assignment-1 that referenced this issue May 5, 2021

Fix the warning of eslint-plugin-react

e1fd3c4

Fix the warning of React version not speicifed in eslint-plugin-react settings. See also: - jsx-eslint/eslint-plugin-react#1955

wholemann mentioned this issue May 5, 2021

Fix the warning of eslint-plugin-react CodeSoom/react-week1-assignment-1#95

Merged

wholemann added a commit to wholemann/react-week1-assignment-1 that referenced this issue May 5, 2021

Fix the warning of eslint-plugin-react

f0a027b

Fix the warning of React version not speicifed in eslint-plugin-react settings. See also: - jsx-eslint/eslint-plugin-react#1955

wholemann mentioned this issue May 5, 2021

Fix the warning of eslint-plugin-react CodeSoom/react-week1-assignment-1#96

Merged

romanstrazanec mentioned this issue Jun 1, 2021

React version not specified in eslint-plugin-react settings appngo-sk/eslint-config#1

Closed

This comment was marked as spam.

Sign in to view

This comment was marked as resolved.

Sign in to view

AlbinoGeek mentioned this issue Mar 23, 2022

eslint --init does not add settings as required by #1955 #3256

Closed

Spider101 mentioned this issue Apr 10, 2022

Upgrade react and storybook Spider101/football-stats-dashboard#155

Merged

3 tasks

kei95 mentioned this issue Apr 27, 2022

Set up lint and prettier for the project ryonryon/trello-clone#7

Merged

ghsable referenced this issue in ghsable/searchForA Jul 5, 2022

update .eslintrc.yml - add settings:react:version

d51cfad

This was referenced Aug 8, 2022

Bug/lint config fix CruzHacks/cruzhacks-2023-website#15

Closed

fix scss/react lint config CruzHacks/cruzhacks-2023-website#17

Merged

julielouie mentioned this issue Sep 22, 2022

Warning: React version not specified in eslint-plugin-react settings (Part 2) #3438

Closed

greenfrvr mentioned this issue Oct 17, 2022

update rn, fix eslint, ts errors akveo/react-native-ui-kitten#1655

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warning: React version not specified in eslint-plugin-react settings. #1955

Warning: React version not specified in eslint-plugin-react settings. #1955

kud commented Aug 22, 2018

ljharb commented Aug 22, 2018

ljharb commented Aug 22, 2018

kud commented Aug 22, 2018

chrisdothtml commented Aug 23, 2018

marcofugaro commented Aug 28, 2018

ljharb commented Aug 28, 2018

marcofugaro commented Aug 28, 2018

chrisdothtml commented Aug 28, 2018

kud commented Aug 29, 2018

bhardy commented Aug 29, 2018 •

edited

Loading

ljharb commented Aug 30, 2018 •

edited

Loading

bhardy commented Aug 30, 2018

ljharb commented Aug 30, 2018

mohsinulhaq commented Sep 22, 2018

ljharb commented Sep 23, 2018

mohsinulhaq commented Sep 23, 2018

ljharb commented Sep 23, 2018

anilanar commented Oct 10, 2018 •

edited

Loading

bertho-zero commented Oct 10, 2018 •

edited

Loading

samhou1988 commented Feb 20, 2021

This comment was marked as spam.

This comment was marked as resolved.

This comment was marked as resolved.

daryazata commented Jun 15, 2022

ljharb commented Jun 16, 2022

MidKnightXI commented Sep 7, 2022

julielouie commented Sep 22, 2022 •

edited

Loading

ljharb commented Sep 22, 2022

julielouie commented Sep 22, 2022

ljharb commented Sep 22, 2022

julielouie commented Sep 22, 2022 •

edited

Loading

Warning: React version not specified in eslint-plugin-react settings. #1955

Warning: React version not specified in eslint-plugin-react settings. #1955

Comments

kud commented Aug 22, 2018

ljharb commented Aug 22, 2018

ljharb commented Aug 22, 2018

kud commented Aug 22, 2018

chrisdothtml commented Aug 23, 2018

marcofugaro commented Aug 28, 2018

ljharb commented Aug 28, 2018

marcofugaro commented Aug 28, 2018

chrisdothtml commented Aug 28, 2018

kud commented Aug 29, 2018

bhardy commented Aug 29, 2018 • edited Loading

ljharb commented Aug 30, 2018 • edited Loading

bhardy commented Aug 30, 2018

ljharb commented Aug 30, 2018

mohsinulhaq commented Sep 22, 2018

ljharb commented Sep 23, 2018

mohsinulhaq commented Sep 23, 2018

ljharb commented Sep 23, 2018

anilanar commented Oct 10, 2018 • edited Loading

bertho-zero commented Oct 10, 2018 • edited Loading

samhou1988 commented Feb 20, 2021

This comment was marked as spam.

This comment was marked as resolved.

This comment was marked as resolved.

daryazata commented Jun 15, 2022

ljharb commented Jun 16, 2022

MidKnightXI commented Sep 7, 2022

julielouie commented Sep 22, 2022 • edited Loading

ljharb commented Sep 22, 2022

julielouie commented Sep 22, 2022

ljharb commented Sep 22, 2022

julielouie commented Sep 22, 2022 • edited Loading

bhardy commented Aug 29, 2018 •

edited

Loading

ljharb commented Aug 30, 2018 •

edited

Loading

anilanar commented Oct 10, 2018 •

edited

Loading

bertho-zero commented Oct 10, 2018 •

edited

Loading

julielouie commented Sep 22, 2022 •

edited

Loading

julielouie commented Sep 22, 2022 •

edited

Loading