-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlay Panel: Interaction with components inside panel template cause panel to hide #14323
Comments
I think is the same as : #14177 |
#14120 (comment) for those that search a workaround Bug also present in v17 |
Well that is not properly a workaround as you don't have the possibility to dismiss the panel by clicking outside of it.... I made some trials and I ended up using event.stopPropagation that in my case I think is the best solution (waiting for a proper bugfix by primeng team). |
This problem is still present if you click the clear icon on the dropdown or if you uncheck the combobox, you can check in the original stack blitz updating primeng version |
Same issue here, with a dropdown in a overlay-panel with |
A fix was merged and is part of v17.1.0, please have a look: https://stackblitz.com/edit/gd88qz-r9ujpp?file=package.json. |
Yesterday I updated primeng version to 17.1.0 on my stackblitz and the problem was still there, but maybe I forgot to run npm i or idk what happend, because, as shown by @anlampe here, I tried again today and actually the clear and the checkbox seems to be working now. The dropdowns with appendTo="body" are still broken though |
@anlampe I tried the demo that you created on stackblitz and both clicking the checkbox and the clear button indeed work, the overlay remains open, that's great. However, the overlay panel still closes when you select an option in the dropdown. |
Yes, I could reproduce it. Unfortunately, my PR was already 2 months old, when it was merged and it seems there was another conflicting change in the meantime. I'll have another look as soon as I've some free time. |
…osed before it handles the click event
…k-event-not-processed-by-overlay Fix #14323: Dropdown fix regression - options overlay is closed before it handles the click event
Fucked up again in 8d69419 |
Describe the bug
If I deselect a value from a dropdown or a checkbox the panel hides
Environment
PrimeNG@16.9.1
Angular@16.2.0
Reproducer
https://stackblitz.com/edit/gd88qz?file=src%2Fapp%2Fdemo%2Foverlay-panel-basic-demo.html
Angular version
16.2.0
PrimeNG version
16.9.1
Build / Runtime
Angular CLI App
Language
TypeScript
Node version (for AoT issues node --version)
18.16.0
Browser(s)
Chrome, Firefox
Steps to reproduce the behavior
Expected behavior
Well I expect the panel to close only if I click outside the panel itself, I click the close icon or i press the esc button on my keyboard
The text was updated successfully, but these errors were encountered: