Fix #14323: Dropdown fix regression - options overlay is closed before it handles the click event #14419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osed before it handles the click event
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14323 created with f52340b
When selecting a dropdown option inside an
OverlayPanelthe click event also has to be processed by the options overlay and theOverlayService. Otherwise theOverlayPanelis not aware that the click on the option is a click on its content =>OverlayPanelis closed. Unfortunately when improving the accessability an older "workaround" which handels the issue was removed and has now been added again.Before:
After:
@cetincakiroglu would be great if you could have a look! 😄