Skip to content

Commit

Permalink
Fixed #942 - Custom target for OverlayPane
Browse files Browse the repository at this point in the history
  • Loading branch information
cagataycivici committed Jul 27, 2021
1 parent 01b5c0f commit ab17ffa
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
12 changes: 7 additions & 5 deletions src/components/overlaypanel/OverlayPanel.vue
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ export default {
},
selfClick: false,
target: null,
eventTarget: null,
outsideClickListener: null,
scrollHandler: null,
resizeListener: null,
Expand Down Expand Up @@ -94,15 +95,16 @@ export default {
}
},
methods: {
toggle(event) {
toggle(event, target) {
if (this.visible)
this.hide();
else
this.show(event);
this.show(event, target);
},
show(event) {
show(event, target) {
this.visible = true;
this.target = event.currentTarget;
this.eventTarget = event.currentTarget;
this.target = target || event.currentTarget;
},
hide() {
this.visible = false;
Expand Down Expand Up @@ -211,7 +213,7 @@ export default {
}
},
isTargetClicked(event) {
return this.target && (this.target === event.target || this.target.contains(event.target));
return (this.eventTarget && (this.eventTarget === event.target || this.eventTarget.contains(event.target)));
},
containerRef(el) {
this.container = el;
Expand Down
5 changes: 3 additions & 2 deletions src/views/overlaypanel/OverlayPanelDoc.vue
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,14 @@ toggle(event) {
<tbody>
<tr>
<td>toggle</td>
<td>event: Browser event</td>
<td>event: Browser event <br />
target: Optional target if event.currentTarget should not be used</td>
<td>Toggles the visibility of the overlay.</td>
</tr>
<tr>
<td>show</td>
<td>event: Browser event <br />
target: Optional target if event.target should not be used</td>
target: Optional target if event.currentTarget should not be used</td>
<td>Shows the overlay.</td>
</tr>
<tr>
Expand Down

0 comments on commit ab17ffa

Please sign in to comment.