Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom target for OverlayPanel #942

Closed
cagataycivici opened this issue Feb 4, 2021 · 1 comment
Closed

Custom target for OverlayPanel #942

cagataycivici opened this issue Feb 4, 2021 · 1 comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add

Comments

@cagataycivici
Copy link
Member

Similar to PrimeFaces, add a target option to Overlay to display the panel relative to a specific element, should use the event target by default.
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Feb 4, 2021
steineggerroland pushed a commit to engineering-steinegger/primevue that referenced this issue Jul 20, 2021
Adds custom target for OverlayPanel primefaces#942
95c7739
steineggerroland pushed a commit to engineering-steinegger/primevue that referenced this issue Jul 20, 2021
Adds custom target for OverlayPanel primefaces#942
d60b8b5
@steineggerroland steineggerroland mentioned this issue Jul 20, 2021
Closed
@steineggerroland
Copy link

We tackle several problems with OverlayPanels, because they don't behave like documented.

Our selenium frontend tests don't work properly, because the implementation uses the currentTarget of the event, which "is only available while the event is being handled", as stated in the specification. When handling events asynchronously this might lead to a null target and exceptions when showing and aligning the OverlayPanel.

This could fix the issue. In my opinion, event.target and not event.currentTarget should be used to align the Panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds custom target for OverlayPanel #942 engineering-steinegger/primevue
2 participants
@cagataycivici @steineggerroland