Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR Checker build failing #4599

Closed
FlipWarthog opened this issue Oct 12, 2023 · 0 comments · Fixed by #4600
Closed

PR Checker build failing #4599

FlipWarthog opened this issue Oct 12, 2023 · 0 comments · Fixed by #4600
Labels
Component: Test Issue or pull request is related to Component Testing

Comments

@FlipWarthog
Copy link
Contributor

Describe the bug

Pr Checker workflow is failing for some tests and overlogging CSS errors from JSDOM

Reproducer

Pr Checker

PrimeVue version

3.36.1-SNAPSHOT

Vue version

3.x

Language

ES6

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@FlipWarthog FlipWarthog added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 12, 2023
@FlipWarthog FlipWarthog mentioned this issue Oct 12, 2023
Merged
tugcekucukoglu added a commit that referenced this issue Oct 13, 2023
@tugcekucukoglu
Merge pull request #4600 from FlipWarthog/test-fix
eda7998 
Fix #4599 - PR Checker build failing
@tugcekucukoglu tugcekucukoglu added the Component: Test Issue or pull request is related to Component Testing label Oct 13, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.37.0 milestone Oct 13, 2023
@tugcekucukoglu tugcekucukoglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 13, 2023
@tugcekucukoglu tugcekucukoglu removed this from the 3.37.0 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Test Issue or pull request is related to Component Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4599 - PR Checker build failing FlipWarthog/primevue
2 participants
@tugcekucukoglu @FlipWarthog