Fix #4599 - PR Checker build failing #4600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@mertsincan I stole your comment from #4512 and included it in the main vitest config. |
FlipWarthog
commented
Oct 12, 2023
Comment on lines
+83
to
+85
| if (event) { | ||
| event.preventDefault(); | ||
| } |
There was a problem hiding this comment.
Test was failing with event undefined due to the call on line 92.
FlipWarthog
commented
Oct 12, 2023
| @@ -79,6 +79,6 @@ describe('Button.vue', () => { | |||
| } | |||
| }); | |||
|
|
|||
| expect(wrapper.html()).toBe(`<button class="p-button p-component" type="button" data-pc-name="button" data-pc-section="root" data-pd-ripple="true"><span class="ml-2 font-bold">Default PrimeVue Button</span></button>`); | |||
| expect(wrapper.html()).toBe(`<button class="p-button p-component" type="button" data-pc-name="button" data-pc-section="root"><span class="ml-2 font-bold">Default PrimeVue Button</span></button>`); | |||
There was a problem hiding this comment.
Still investigating this. I think it's just a ripple config change?
There was a problem hiding this comment.
Investigated, ripple is disabled in the default configs which the tests are using so this is a correct assert.
FlipWarthog
commented
Oct 12, 2023
| @@ -37,7 +37,7 @@ describe('Rating.vue', () => { | |||
| it('When star is clicked, onOptionClick method should triggered', async () => { | |||
| await wrapper.find('.p-rating-item').trigger('click'); | |||
|
|
|||
| expect(wrapper.find('.p-focus').exists()).toBe(true); | |||
| expect(wrapper.find('[data-p-focused="true"]').exists()).toBe(true); | |||
There was a problem hiding this comment.
p-focus is not added on click, just keyboard nav, so looking for the data attribute instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4599 - PR Checker build failing
Creating as a draft to test the workflows