Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build & data for v1 tokens #874

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Remove build & data for v1 tokens #874

merged 1 commit into from
Apr 19, 2024

Conversation

lukasoppermann
Copy link
Contributor

@lukasoppermann lukasoppermann commented Apr 9, 2024

Summary

Changes:

  • removed:
    • ./data folder which had v1 tokens
    • ./scripts/build.ts which was the v1 build file
      • ./scripts/lib/mode-collection.ts used in v1 build script
      • ./scripts/lib/variable-collection.ts used in v1 build script
    • ./src/utils-v1.ts used in mode-collection.ts and variable-collection.ts
    • ./tsconfig.build.json used when running ./scripts/build.ts (v1 build script)
  • modfied:
    • package.json
      • rm dependencies that are used only for v1 build process
      • rm "main": "dist/js/index.js" and "types": "dist/js/index.d.ts" and solely reyling on files now
      • rm "build": "ts-node ./scripts/build.ts && tsc --project tsconfig.build.json", which is the v1 build script
        • rm npm run build from prepack
    • replace npm run build with npm run build:next in .husky/pre-push
    • rm oldTokens (v1 tokens) from .github/workflows/hasChanged.yml
    • rm npm run build from .github/workflows/diff.yml
    • rm npm run build from .github/workflows/deploy_preview.yml
    • rm npm run build from .github/workflows/deploy.yml

Copy link

changeset-bot bot commented Apr 9, 2024

🦋 Changeset detected

Latest commit: 6471905

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Variables changed
No variables changed

@lukasoppermann lukasoppermann mentioned this pull request Apr 9, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants