-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PageLayout): use dvh to support the correct height on iOS devices #2251
Conversation
🦋 Changeset detectedLatest commit: e907718 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
From the testing @joshblack and I did, it looks like the experience of using |
Notes
If we cannot do any of above, prioritize the desktop experience |
Added a quick check for the touch-callout property and should be good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @joshblack! Ship it 🚢
Closes https://github.com/github/primer/issues/1211
This PR updates the
useStickyPaneHeight
hook inPageLayout
to usedvh
for values, if it's supported on the user's device.Note: this property seems to have a regression in Safari 15.6: https://bugs.webkit.org/show_bug.cgi?id=242758
Screenshots
For a quick overview of dvh:
This behaves as intended except for Safari on macOS. It seems like Safari is including the height of the title bar in this situation instead of the intended height (based on the height difference being the same height as the title bar).
It seems like this bug is captured over in: https://bugs.webkit.org/show_bug.cgi?id=242758 and was a regression in Safari 15.6
Merge checklist