Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking #2365

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Release tracking #2365

merged 1 commit into from
Oct 12, 2022

Conversation

primer-css
Copy link
Contributor

@primer-css primer-css commented Sep 23, 2022

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/react@35.11.0

Minor Changes

Patch Changes

@primer-css primer-css requested review from a team and rezrah September 23, 2022 15:44
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass
  • Docs and Storybook open in a browser
  • Successful integration test with GitHub Projects as a primary consumer of Primer React
    • Install the Release Candidate
    • Verify no new build errors appear
    • Verify no new linting errors appear
    • Verify no new browser console errors appear
    • Verify unit tests and E2E tests pass
    • Manually test critical paths (Tip: Use the provided tests project boards)
    • Manually test release-specific bugfixes and/or features work as described
  • Works in CodeSandbox or StackBlitz
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🤔 Sanity test

  • All bugfixes in this release have resolved their corrosponding issues
  • All new features in this release have been tested and verified as compatible with GitHub Projects
  • No noticeable regressions have not been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

🚢 After merge

  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

Please also leave any testing notes as a comment on this pull request. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to maintainers.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 77.65 KB (0%)
dist/browser.umd.js 78.31 KB (0%)

@primer-css primer-css temporarily deployed to github-pages September 23, 2022 15:53 Inactive
@primer-css primer-css temporarily deployed to github-pages September 23, 2022 18:13 Inactive
@primer-css primer-css temporarily deployed to github-pages September 23, 2022 18:24 Inactive
@primer-css primer-css temporarily deployed to github-pages September 26, 2022 17:15 Inactive
@primer-css primer-css temporarily deployed to github-pages September 26, 2022 23:41 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch 2 times, most recently from 036ffa7 to 7099d68 Compare September 27, 2022 16:06
@primer-css primer-css temporarily deployed to github-pages September 27, 2022 16:12 Inactive
@primer-css primer-css temporarily deployed to github-pages September 27, 2022 18:33 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch 2 times, most recently from 35c02c9 to 182fcbc Compare September 28, 2022 02:54
@primer-css primer-css temporarily deployed to github-pages September 28, 2022 03:00 Inactive
@primer-css primer-css temporarily deployed to github-pages September 28, 2022 03:28 Inactive
@primer-css primer-css temporarily deployed to github-pages September 28, 2022 17:20 Inactive
@primer-css primer-css temporarily deployed to github-pages September 28, 2022 18:33 Inactive
@primer-css primer-css temporarily deployed to github-pages September 28, 2022 20:09 Inactive
@primer-css primer-css temporarily deployed to github-pages October 10, 2022 17:12 Inactive
@primer-css primer-css temporarily deployed to github-pages October 10, 2022 18:01 Inactive
@primer-css primer-css temporarily deployed to github-pages October 10, 2022 19:34 Inactive
@mattcosta7
Copy link
Collaborator

Update 1: paste-markdown published to github registry: https://github.com/github/paste-markdown/actions/runs/3220920799/jobs/5268224253

Update 2: there are CI checks that fail in memex: github/memex#12589. Do we need to mock CSS.supports for jest?

@siddharthkp re 2 - https://github.com/github/memex/pull/12478/files#diff-0aae7d3a8cad9eaa160c8b69c90947dd09dddfe9fa4c92e30adc2c9ad912f31bR12

I had a PR adding this in memex from a prerelease build earlier of this release channel. should be easy to drop that in

@primer-css primer-css temporarily deployed to github-pages October 10, 2022 19:59 Inactive
@primer-css primer-css temporarily deployed to github-pages October 10, 2022 20:09 Inactive
@primer-css primer-css temporarily deployed to github-pages October 10, 2022 21:29 Inactive
@primer-css primer-css temporarily deployed to github-pages October 11, 2022 02:17 Inactive
@primer-css primer-css temporarily deployed to github-pages October 11, 2022 05:43 Inactive
@primer-css primer-css temporarily deployed to github-pages October 11, 2022 15:45 Inactive
@primer-css primer-css temporarily deployed to github-pages October 11, 2022 18:52 Inactive
@primer-css primer-css temporarily deployed to github-pages October 11, 2022 20:57 Inactive
@primer-css primer-css temporarily deployed to github-pages October 11, 2022 21:26 Inactive
@primer-css primer-css temporarily deployed to github-pages October 12, 2022 12:23 Inactive
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the tests, time to cut a release :)

@siddharthkp siddharthkp merged commit c4181e5 into main Oct 12, 2022
@siddharthkp siddharthkp deleted the changeset-release/main branch October 12, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants