Remove non-tab elements from TabNav focus zone
#2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c8f19ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…-focus-zone' of https://github.com/primer/react into 2319-tabnav-should-exclude-buttons-within-tabs-from-the-focus-zone
joshblack
approved these changes
Sep 23, 2022
…bs-from-the-focus-zone
iansan5653
deleted the
2319-tabnav-should-exclude-buttons-within-tabs-from-the-focus-zone
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are focuseable elements inside
TabNav(particularly inside theTabs themselves) they should not be included in the arrow-key navigation. For example, this menu button should be focuseable via Tab, not via arrow keys:This change filters out any elements without the role
tabfrom the focus zone. This fixes #2319 - for more context, please see that issue.Merge checklist
[ ] Added/updated documentationTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.