Reintroduce aria-hidden=true asterisk changes #3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove aria-hidden=true from spans with required asterisk * Create pink-beds-fetch.md --------- Co-authored-by: Cole Bemis <colebemis@github.com>
🦋 Changeset detectedLatest commit: aa1a6fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7 tasks
size-limit report 📦
|
adrianababakanian
temporarily deployed
to
github-pages
GitHub Actions
Inactive
adrianababakanian
changed the title
adrianababakanian
temporarily deployed
to
github-pages
GitHub Actions
Inactive
adrianababakanian
changed the title
adrianababakanian
force-pushed
the
adrianababakanian/reintroduce-pagination-control-changes
branch
from
4e05c8e
to
b9a3895
Compare
broccolinisoup
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
👋🏻 Hi @adrianababakanian , thank you so much for this PR!
Looking at the follow up https://github.com/github/repos/issues/7164 and the PR that removes checkbox names, I think we are now safe to introduce these changes 👍🏻 Thanks for your thorough work and your patience with us while we are re-introcuding the PRs 🙏🏻
adrianababakanian
deleted the
adrianababakanian/reintroduce-pagination-control-changes
branch
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here.
Reintroduces the changes from 47b7ea0 that had to be reverted for the previous release.
It may be worth noting that I added in dfbf551 after the initial commit above to address a snapshot regression, so cherry-picked it back in here as well.Edit: never mind, the snapshot updates were for a different PR of mine!Screenshots
See #3320 for the details!
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.