Revert "Reintroduce aria-hidden=true asterisk changes"

[broccolinisoup]

Reverts #3439

So sorry @adrianababakanian for reverting this again but there are still failing tests at dotcom that relys on having aria-hidden="true" attribute https://github.com/github/github/actions/runs/5418650975/jobs/9850965487?pr=278549

Let us know if you need more support on re-introducing this PR.

[changeset-bot]

⚠️ No Changeset found

Latest commit: cc254c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	101.82 KB (+0.01% 🔺)
dist/browser.umd.js	102.37 KB (+0.01% 🔺)

[adrianababakanian]

Ah, sorry to have you need to revert again @broccolinisoup ! I thought I caught all of the failing dotcom CI with my canary version installed 😬 Per your understanding, are the four failing tests across the two jobs here a definitive list of what needs to updated in dotcom?

🤞 that third time's a charm 😅

[broccolinisoup]

@adrianababakanian No worries at all!

Per your understanding, are the four failing tests across the two jobs here a definitive list of what needs to updated in dotcom?

I wouldn't rely on these failures as definitive tests. There might be other jest failures that don't show up on the integration PR.

What I would suggest is installing "0.0.0-20230630025459" version (currently this PR's latest canary) on your dotcom PR that you are "fixing" issues/tests on. In this case I think https://github.com/github/github/pull/278843. After installing the canary version on that PR if there are still failing tests at dotcom you can address them immediately on your PR. Once you see all CI checks are green on your https://github.com/github/github/pull/278843, that means we are good to go 🙂 Is that helpful? Would you need a hand with any of these?

Update: Sorry I was confused and thought this is the re-introduce PR 😬 What I would suggest is installing the canary of your PR that you will re-introduce these changes 😊