-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix: ActionList item label weight and spacing if description exists #3490
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f969a3a
fix item with description
langermank 36b5967
Create kind-eggs-cheer.md
langermank 9c3b809
Merge branch 'main' into fix-actionlist-item-bold
langermank 46edde9
Merge branch 'main' into fix-actionlist-item-bold
langermank 45d7b83
test(vrt): update snapshots
langermank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@primer/react": patch | ||
--- | ||
|
||
Bug fix: ActionList item label weight and spacing if description exists |
Binary file modified
BIN
+1.37 KB
(100%)
...onList.test.ts-snapshots/ActionList-Block-Description-dark-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.27 KB
(100%)
...ActionList.test.ts-snapshots/ActionList-Block-Description-dark-dimmed-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.44 KB
(100%)
...ist.test.ts-snapshots/ActionList-Block-Description-dark-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.14 KB
(100%)
...onents/ActionList.test.ts-snapshots/ActionList-Block-Description-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.37 KB
(100%)
...onList.test.ts-snapshots/ActionList-Block-Description-dark-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.41 KB
(100%)
...nList.test.ts-snapshots/ActionList-Block-Description-light-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.45 KB
(100%)
...st.test.ts-snapshots/ActionList-Block-Description-light-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.48 KB
(100%)
...nents/ActionList.test.ts-snapshots/ActionList-Block-Description-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.4 KB
(100%)
...nList.test.ts-snapshots/ActionList-Block-Description-light-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+773 Bytes
(100%)
...ActionList.test.ts-snapshots/ActionList-Disabled-Item-dark-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+789 Bytes
(100%)
...nts/ActionList.test.ts-snapshots/ActionList-Disabled-Item-dark-dimmed-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+873 Bytes
(110%)
...ionList.test.ts-snapshots/ActionList-Disabled-Item-dark-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+787 Bytes
(100%)
...components/ActionList.test.ts-snapshots/ActionList-Disabled-Item-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+773 Bytes
(100%)
...ActionList.test.ts-snapshots/ActionList-Disabled-Item-dark-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+789 Bytes
(100%)
...ctionList.test.ts-snapshots/ActionList-Disabled-Item-light-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+822 Bytes
(100%)
...onList.test.ts-snapshots/ActionList-Disabled-Item-light-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+760 Bytes
(100%)
...omponents/ActionList.test.ts-snapshots/ActionList-Disabled-Item-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+789 Bytes
(100%)
...ctionList.test.ts-snapshots/ActionList-Disabled-Item-light-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+150 Bytes
(100%)
...nList.test.ts-snapshots/ActionList-Inline-Description-dark-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+80 Bytes
(100%)
...ctionList.test.ts-snapshots/ActionList-Inline-Description-dark-dimmed-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+5 Bytes
(100%)
...st.test.ts-snapshots/ActionList-Inline-Description-dark-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
...nents/ActionList.test.ts-snapshots/ActionList-Inline-Description-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+150 Bytes
(100%)
...nList.test.ts-snapshots/ActionList-Inline-Description-dark-tritanopia-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2 Bytes
(100%)
...List.test.ts-snapshots/ActionList-Inline-Description-light-colorblind-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+2 Bytes
(100%)
...t.test.ts-snapshots/ActionList-Inline-Description-light-high-contrast-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3 Bytes
(100%)
...ents/ActionList.test.ts-snapshots/ActionList-Inline-Description-light-linux.png
Oops, something went wrong.
Binary file modified
BIN
+5 Bytes
(100%)
...List.test.ts-snapshots/ActionList-Inline-Description-light-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+777 Bytes
(100%)
.../ActionList.test.ts-snapshots/ActionList-Multi-Select-dark-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+765 Bytes
(100%)
...ents/ActionList.test.ts-snapshots/ActionList-Multi-Select-dark-dimmed-linux.png
Oops, something went wrong.
Binary file modified
BIN
+860 Bytes
(100%)
...tionList.test.ts-snapshots/ActionList-Multi-Select-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+853 Bytes
(100%)
.../components/ActionList.test.ts-snapshots/ActionList-Multi-Select-dark-linux.png
Oops, something went wrong.
Binary file modified
BIN
+777 Bytes
(100%)
.../ActionList.test.ts-snapshots/ActionList-Multi-Select-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+816 Bytes
(100%)
...ActionList.test.ts-snapshots/ActionList-Multi-Select-light-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+816 Bytes
(100%)
...ionList.test.ts-snapshots/ActionList-Multi-Select-light-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+796 Bytes
(100%)
...components/ActionList.test.ts-snapshots/ActionList-Multi-Select-light-linux.png
Oops, something went wrong.
Binary file modified
BIN
+816 Bytes
(100%)
...ActionList.test.ts-snapshots/ActionList-Multi-Select-light-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+789 Bytes
(100%)
...ActionList.test.ts-snapshots/ActionList-Single-Select-dark-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+808 Bytes
(100%)
...nts/ActionList.test.ts-snapshots/ActionList-Single-Select-dark-dimmed-linux.png
Oops, something went wrong.
Binary file modified
BIN
+904 Bytes
(110%)
...ionList.test.ts-snapshots/ActionList-Single-Select-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+829 Bytes
(100%)
...components/ActionList.test.ts-snapshots/ActionList-Single-Select-dark-linux.png
Oops, something went wrong.
Binary file modified
BIN
+789 Bytes
(100%)
...ActionList.test.ts-snapshots/ActionList-Single-Select-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+806 Bytes
(100%)
...ctionList.test.ts-snapshots/ActionList-Single-Select-light-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+841 Bytes
(110%)
...onList.test.ts-snapshots/ActionList-Single-Select-light-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+783 Bytes
(100%)
...omponents/ActionList.test.ts-snapshots/ActionList-Single-Select-light-linux.png
Oops, something went wrong.
Binary file modified
BIN
+806 Bytes
(100%)
...ctionList.test.ts-snapshots/ActionList-Single-Select-light-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+524 Bytes
(100%)
...test.ts-snapshots/ActionList-Text-Wrap-And-Truncation-dark-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+503 Bytes
(100%)
...ist.test.ts-snapshots/ActionList-Text-Wrap-And-Truncation-dark-dimmed-linux.png
Oops, something went wrong.
Binary file modified
BIN
+557 Bytes
(100%)
...t.ts-snapshots/ActionList-Text-Wrap-And-Truncation-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+598 Bytes
(100%)
...ActionList.test.ts-snapshots/ActionList-Text-Wrap-And-Truncation-dark-linux.png
Oops, something went wrong.
Binary file modified
BIN
+524 Bytes
(100%)
...test.ts-snapshots/ActionList-Text-Wrap-And-Truncation-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+551 Bytes
(100%)
...est.ts-snapshots/ActionList-Text-Wrap-And-Truncation-light-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+461 Bytes
(100%)
....ts-snapshots/ActionList-Text-Wrap-And-Truncation-light-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+608 Bytes
(100%)
...ctionList.test.ts-snapshots/ActionList-Text-Wrap-And-Truncation-light-linux.png
Oops, something went wrong.
Binary file modified
BIN
+551 Bytes
(100%)
...est.ts-snapshots/ActionList-Text-Wrap-And-Truncation-light-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+474 Bytes
(100%)
....test.ts-snapshots/ActionMenu-Groups-And-Descriptions-dark-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+368 Bytes
(100%)
...Menu.test.ts-snapshots/ActionMenu-Groups-And-Descriptions-dark-dimmed-linux.png
Oops, something went wrong.
Binary file modified
BIN
+503 Bytes
(100%)
...st.ts-snapshots/ActionMenu-Groups-And-Descriptions-dark-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+346 Bytes
(100%)
.../ActionMenu.test.ts-snapshots/ActionMenu-Groups-And-Descriptions-dark-linux.png
Oops, something went wrong.
Binary file modified
BIN
+474 Bytes
(100%)
....test.ts-snapshots/ActionMenu-Groups-And-Descriptions-dark-tritanopia-linux.png
Oops, something went wrong.
Binary file modified
BIN
+516 Bytes
(100%)
...test.ts-snapshots/ActionMenu-Groups-And-Descriptions-light-colorblind-linux.png
Oops, something went wrong.
Binary file modified
BIN
+745 Bytes
(100%)
...t.ts-snapshots/ActionMenu-Groups-And-Descriptions-light-high-contrast-linux.png
Oops, something went wrong.
Binary file modified
BIN
+504 Bytes
(100%)
...ActionMenu.test.ts-snapshots/ActionMenu-Groups-And-Descriptions-light-linux.png
Oops, something went wrong.
Binary file modified
BIN
+516 Bytes
(100%)
...test.ts-snapshots/ActionMenu-Groups-And-Descriptions-light-tritanopia-linux.png
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be the token space-
1
than 4px?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can someone let me know what the syntax is meant to look like to access the spacing token here? I couldn't figure it out, gave up and used px 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unlessssssss, styled-system doesn't understand logical properties like marginBlockEnd, only marginRight because the last release was in 2019 (open issue).
We could figure out how to add support for logical properties in primer/react or we could add '4px' for now and move on. I say 4px and move on. (only for primer, look the other way @maraisr 😛)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SIGH haha okay, thanks @siddharthkp!