Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changed components to the changesets #3514

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

broccolinisoup
Copy link
Member

I didn't realised this PR didn't have changed components in the changeset because it is an old one. I enabled "Merge when ready" and updated the branch with the latest main. Although the changeset job failed it still merged the PR 🤷🏻‍♀️ So just adding changed components to its changeset. I also realised that #3490 doesn't have changed components either so adding to that one as well.

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@broccolinisoup broccolinisoup requested review from a team and langermank July 12, 2023 01:29
@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023

⚠️ No Changeset found

Latest commit: ba03615

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 102.31 KB (0%)
dist/browser.umd.js 102.88 KB (0%)

@siddharthkp siddharthkp added this pull request to the merge queue Jul 12, 2023
Merged via the queue into main with commit d05ef24 Jul 12, 2023
@siddharthkp siddharthkp deleted the bs/changed-components-add branch July 12, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants