Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

featL: Log normal pool type #35

Closed
wants to merge 172 commits into from
Closed

featL: Log normal pool type #35

wants to merge 172 commits into from

Conversation

0xJepsen
Copy link
Contributor

Closes #31

@clemlak
Copy link
Contributor

clemlak commented Feb 29, 2024

I'm going to update the LogNormal strategy to remove tau, do you want to merge this branch now or wait and update it before merging?

@0xJepsen
Copy link
Contributor Author

0xJepsen commented Mar 1, 2024

I'm going to update the LogNormal strategy to remove tau, do you want to merge this branch now or wait and update it before merging?

lets, wait. I will revisit this once the contracts are frozen.

@Alexangelj Alexangelj added the 🛠️ kit Anything related to the DFMM kit label Mar 13, 2024
kinrezC and others added 18 commits March 18, 2024 12:31
@kinrezC
test for LP token balance delta on allocate
95b6928
@kinrezC
reproduce audit finding
8cff3fc
@kinrezC
fix liquidity management order of ops
8c675cc
@kinrezC
fix lptoken allocate test assertions
0557365
@clemlak
fix: optimize duplicate tokens loop check
27381ed
@clemlak
fix: DFMM init now returns the totalLiquidity of the pool
8040789
@clemlak
fix: check if token is WETH in _transferFrom
d30b822
@clemlak
test: use WETH address in _transferFrom tests
43b769a
@clemlak
feat: avoid stuck ETH in _transferFrom
e1c4eea
@clemlak
test: add test_DFMM_transferFrom_UsesWETH
849cac0
@clemlak
test: add test_DFMM_transferFrom_UsesWETHAndRefunds
6594c38
@clemlak
feat: add balance zero check before refunding ETH in _transferFrom
c62ca0e
@clemlak
chore: add commit to OZ clone function link
fe89db1
@clemlak
feat: add InvalidReserves error
bf1102c
@clemlak
fix: compare reserves and tokens length in init
ed37a9b
@clemlak
fix: update controller fees minting in swap
1fe6809
@clemlak
test: update test_DFMM_swap_MintsLPTokensToFeeCollector
6d3eeb9
@clemlak
fix: typo in _computeDeallocateDeltasGivenDeltaL NatSpec
051f786
clemlak and others added 27 commits March 29, 2024 18:18
@clemlak
feat: use EPSILON to check invariant in LogNormal init
5a7b2bc
@clemlak
feat: use EPSILON to check invariant in NTokenG3M init
6ecc8e7
@clemlak
Merge branch 'fix/spearbit-audit' into fix/controller-swap-fees
d9f23f8
@clemlak
Merge pull request #80 from primitivefinance/fix/controller-swap-fees
86b6b0b 
Fix/controller swap fees
@clemlak
Merge branch 'fix/spearbit-audit' into fix/minor-issues
af6ac26
@clemlak
Merge pull request #98 from primitivefinance/fix/minor-issues
62eeb36 
Fix/minor issues
@clemlak
Merge branch 'fix/spearbit-audit' into fix/g3m-weight-check
fa3af60
@clemlak
Merge pull request #102 from primitivefinance/fix/g3m-weight-check
c38bb61 
Fix/g3m weight check
@clemlak
Merge branch 'fix/spearbit-audit' into fix/g3m-trading-function-rounding
8cb531c
@clemlak
Merge pull request #101 from primitivefinance/fix/g3m-trading-functio…
274696a 
…n-rounding

Fix/g3m trading function rounding
@clemlak
Merge branch 'fix/spearbit-audit' into fix/missing-modifier-ntokeng3m
22313f9
@clemlak
Merge pull request #103 from primitivefinance/fix/missing-modifier-nt…
7406c0e 
…okeng3m

Fix/missing modifier ntokeng3m
@clemlak
Merge pull request #99 from primitivefinance/fix/ntoken-deltas-array-…
49a20c7 
…check

fix: add deltas array length check in NTokenStrategy
@clemlak
Merge pull request #111 from primitivefinance/fix/ntoken-g3m-rounding
74719d5 
fix: use muldiv in NTokenG3M math
@clemlak
Merge branch 'fix/spearbit-audit' into fix/log-normal-bounded-params
f332e3d
@clemlak
Merge pull request #93 from primitivefinance/fix/log-normal-bounded-p…
a6ed4ed 
…arams

Fix/log normal bounded params
@clemlak
fix: use computeDeltaLiquidity in ConstantSum init
cda904a
@clemlak
Merge branch 'fix/spearbit-audit' into fix/total-liquidity-init
cebcdca
@clemlak
Merge pull request #107 from primitivefinance/fix/total-liquidity-init
8bff684 
Fix/total liquidity init
@clemlak
Merge branch 'fix/spearbit-audit' into fix/strategy-lib-muldiv
1972c1c
@clemlak
test: increase default X reserve for LogNormal pools
aa9e127
@clemlak
Merge pull request #100 from primitivefinance/fix/strategy-lib-muldiv
32a5572 
Fix/strategy lib muldiv
@0xJepsen
Merge branch 'fix/spearbit-audit' into log-normal-pool-type
5444a0f
@0xJepsen
new bindings and log normal
bfcd312
@0xJepsen
comment on constantsumsolver
b8462b7
@0xJepsen
chore: fmt
a0d9130
@0xJepsen
chore: byte encoding in log normal solver
df79c79
@0xJepsen 0xJepsen mentioned this pull request Apr 2, 2024
Open
1 task
@0xJepsen 0xJepsen closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Autoparallel Autoparallel Awaiting requested review from Autoparallel

@zachdt zachdt Awaiting requested review from zachdt

@kinrezC kinrezC Awaiting requested review from kinrezC

@Alexangelj Alexangelj Awaiting requested review from Alexangelj

@clemlak clemlak Awaiting requested review from clemlak

Assignees
No one assigned
Labels
🛠️ kit Anything related to the DFMM kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: impl pool trait for log normal strategy
4 participants
@0xJepsen @clemlak @Alexangelj @kinrezC