Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid raising error when removing non-existent image #206

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

carlosejimenez
Copy link
Collaborator

@carlosejimenez carlosejimenez commented Aug 15, 2024

In swebench/harness/docker_utils.py sometimes, during cleaning, an image is marked for removal even if it doesn't exist (tbh not 100% why this happens), but when we try to remove a non-existent image, we get an error that interrupts execution.

There are currently no consequences to trying to remove a non-existent image, and the interruption is annoying, so we now should avoid throwing an error in those cases and instead just log the incident. We'll still get errors in other cases.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.18%. Comparing base (c2b3cef) to head (f76dabf).
Report is 10 commits behind head on main.

Files Patch % Lines
swebench/harness/docker_utils.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   58.09%   58.18%   +0.09%     
==========================================
  Files          20       20              
  Lines        1971     1973       +2     
==========================================
+ Hits         1145     1148       +3     
+ Misses        826      825       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlosejimenez carlosejimenez merged commit d9bf376 into main Aug 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant