Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid raising error when removing non-existent image #206

Merged
merged 2 commits into from
Aug 17, 2024
Merged

avoid raising error when removing non-existent image #206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52e240b
avoid raising error when removing non-existent image
carlosejimenez Aug 15, 2024
f76dabf
Update docker_utils.py
carlosejimenez Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion swebench/harness/docker_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,12 @@ def remove_image(client, image_id, logger=None):
log_error = logger.info
log_info = logger.info
raise_error = False

try:
log_info(f"Attempting to remove image {image_id}...")
client.images.remove(image_id, force=True)
log_info(f"Image {image_id} removed.")
except docker.errors.ImageNotFound:
log_info(f"Image {image_id} not found, removing has no effect.")
except Exception as e:
if raise_error:
raise e
Expand Down
Loading