Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement advisory locking #1479

Merged
merged 6 commits into from
Feb 9, 2021
Merged

Implement advisory locking #1479

merged 6 commits into from
Feb 9, 2021

Conversation

tomhoule
Copy link
Contributor

closes #1118

@tomhoule tomhoule assigned tomhoule and unassigned tomhoule Dec 21, 2020
@tomhoule tomhoule added the tech/engines/migration engine Issue in the Migration Engine label Dec 21, 2020
@tomhoule tomhoule added this to the 2.14.0 milestone Dec 21, 2020
@tomhoule tomhoule force-pushed the migration-engine/advisory-locking branch from 4af14fd to 641b47e Compare December 23, 2020 14:51
@tomhoule tomhoule force-pushed the migration-engine/advisory-locking branch 2 times, most recently from f84c0b8 to 86f814e Compare January 4, 2021 15:56
@tomhoule tomhoule force-pushed the migration-engine/advisory-locking branch from 86f814e to 4ac0056 Compare January 11, 2021 12:16
@tomhoule tomhoule force-pushed the migration-engine/advisory-locking branch from 4ac0056 to 7efb442 Compare January 20, 2021 15:16
@tomhoule tomhoule force-pushed the migration-engine/advisory-locking branch 2 times, most recently from 7d2c117 to 762e942 Compare February 8, 2021 10:18
@tomhoule tomhoule marked this pull request as ready for review February 8, 2021 10:19
tomhoule
tomhoule commented Feb 8, 2021
View reviewed changes
migration-engine/migration-engine-tests/tests/migrations/advisory_locking.rs
}
}

async fn mysql_8_test_api(args: TestAPIArgs) -> TestApi {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've thought about reducing the verbosity here quite a bit. Ideas are very welcome

@tomhoule tomhoule force-pushed the migration-engine/advisory-locking branch from cd6c562 to 944c462 Compare February 8, 2021 13:28
yoshuawuyts
yoshuawuyts reviewed Feb 8, 2021
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've found some issues that may be important to address. I'm not an expert on the codebase or domain, so I can't tell for sure. But I hope this is helpful regardless!

migration-engine/connectors/sql-migration-connector/src/flavour/mysql.rs Outdated Show resolved Hide resolved
migration-engine/connectors/sql-migration-connector/src/flavour/mssql.rs Show resolved Hide resolved
migration-engine/connectors/sql-migration-connector/src/flavour/postgres.rs Show resolved Hide resolved
migration-engine/connectors/sql-migration-connector/src/flavour/sqlite.rs Outdated Show resolved Hide resolved
@tomhoule tomhoule force-pushed the migration-engine/advisory-locking branch from 1fc98c7 to 3e329bd Compare February 8, 2021 15:45
@tomhoule tomhoule merged commit 943fce8 into master Feb 9, 2021
@tomhoule tomhoule deleted the migration-engine/advisory-locking branch February 9, 2021 11:13
@Jolg42 Jolg42 modified the milestones: 2.14.0, 2.17.0 Feb 25, 2021
@benbjohnson benbjohnson mentioned this pull request Jan 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts left review comments

Assignees
No one assigned
Labels
tech/engines/migration engine Issue in the Migration Engine
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.

Implement database locking in the migration engine
3 participants
@tomhoule @yoshuawuyts @Jolg42