Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement advisory locking #1479

Merged
merged 6 commits into from
Feb 9, 2021
Merged

Implement advisory locking #1479

merged 6 commits into from
Feb 9, 2021

Commits on Feb 8, 2021

  1. Implement advisory locking in the migration engine 

    This prevents multiple migration engines to concurrently update a
database, like other migration tools do.

closes #1118
    @tomhoule
    tomhoule committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    7ea073a View commit details
    Browse the repository at this point in the history

  2. Fix clippy warnings

    @tomhoule
    tomhoule committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    e3ab740 View commit details
    Browse the repository at this point in the history

  3. Comment tweaks

    @tomhoule
    tomhoule committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    8d32970 View commit details
    Browse the repository at this point in the history

  4. Set locking mode on SQLite in MigrationConnector::acquire_lock()

    @tomhoule
    tomhoule committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    59998db View commit details
    Browse the repository at this point in the history

  5. Set advisory lock timeout to 10 seconds on MySQL 

    Just for consistency with postgres
    @tomhoule
    tomhoule committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    3e329bd View commit details
    Browse the repository at this point in the history

  6. Explain why we don't use an explicit timeout on mssql

    @tomhoule
    tomhoule committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    2fd2c73 View commit details
    Browse the repository at this point in the history