fix(quaint/DA): handle JSON parsing engines side so that we can correctly handle i64s
#4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unexclude common_types test for pg, neon, and PS
CodSpeed Performance ReportMerging #4883 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
Druue
changed the title
i64si64s
|
I think we can also get rid of this block in |
✅ WASM query-engine performance won't change substantially (0.987x)Full benchmark reportAfter changes in 374fc28 |
remove special handling for "$__prisma_null"
SevInf
reviewed
May 23, 2024
SevInf
reviewed
May 23, 2024
… <-> DA contract. To be re-enabled and re-evaluated in a follow-up PR per convo with @SevInf
Co-authored-by: Serhii Tatarintsev <tatarintsev@prisma.io>
SevInf
reviewed
May 24, 2024
| @@ -59,6 +59,7 @@ jobs: | |||
|
|
|||
| - name: Run benchmarks | |||
| id: bench | |||
| if: false | |||
There was a problem hiding this comment.
Note for posteriority: temprarily disabled, as we can't run benchmarks against older version of WASM engine without using driver adapters too: https://github.com/prisma/team-orm/issues/1152
SevInf
approved these changes
May 24, 2024
SevInf
added a commit
that referenced
this pull request
May 24, 2024
…an correctly handle `i64`s (#4883)" This reverts commit f742678. Temporary reverting the change. It is interdependent with prisma/prisma#24269 and neither PR works correctly without the other. The plan was to let engines CI to temporarily go red and fix it immediately by merging client PR. However, engine release pipeline is broken for unrelated reason and this is not possible. Just to limit amount of broken things in progress, we are reverting original PR. It is expected we restore it with no changes once release pipeline is fixed.
SevInf
pushed a commit
that referenced
this pull request
May 24, 2024
…an correctly handle `i64`s (#4883)" (#4886) This reverts commit f742678. Temporary reverting the change. It is interdependent with prisma/prisma#24269 and neither PR works correctly without the other. The plan was to let engines CI to temporarily go red and fix it immediately by merging client PR. However, engine release pipeline is broken for unrelated reason and this is not possible. Just to limit amount of broken things in progress, we are reverting original PR. It is expected we restore it with no changes once release pipeline is fixed.
SevInf
pushed a commit
that referenced
this pull request
May 28, 2024
…ctly handle `i64`s (#4883) * One half of the fix for: prisma/prisma#23926 * Unexcludes pg, neon, and PS for the through_relations::common_types test * Instead of receiving pre-handled JSON by DAs, we now expect strings and will perform JSON parsing in Quaint. * Removed special handling for "$__prisma_null" due to the aforementioned * Temporarily disable wasm-benchmarks due to breaking change in engines <-> DA contract. To be re-enabled and re-evaluated in a follow-up PR per convo with @SevInf --------- Co-authored-by: Serhii Tatarintsev <tatarintsev@prisma.io>
Merged
SevInf
pushed a commit
that referenced
this pull request
May 29, 2024
* One half of the fix for: prisma/prisma#23926 * Unexcludes pg, neon, and PS for the through_relations::common_types test * Instead of receiving pre-handled JSON by DAs, we now expect strings and will perform JSON parsing in Quaint. * Removed special handling for "$__prisma_null" due to the aforementioned * Temporarily disable wasm-benchmarks due to breaking change in engines <-> DA contract. To be re-enabled and re-evaluated in a follow-up PR per convo with @SevInf --------- Co-authored-by: Sophie <29753584+Druue@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unexclude
common_typestest for pg, neon, and PSrelated prisma/prisma#23926