Restore #4883 #4891
Merged
Restore #4883 #4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctly handle `i64`s (#4883) * One half of the fix for: prisma/prisma#23926 * Unexcludes pg, neon, and PS for the through_relations::common_types test * Instead of receiving pre-handled JSON by DAs, we now expect strings and will perform JSON parsing in Quaint. * Removed special handling for "$__prisma_null" due to the aforementioned * Temporarily disable wasm-benchmarks due to breaking change in engines <-> DA contract. To be re-enabled and re-evaluated in a follow-up PR per convo with @SevInf --------- Co-authored-by: Serhii Tatarintsev <tatarintsev@prisma.io>
CodSpeed Performance ReportMerging #4891 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
|
Merge with red tests is expected, we need prisma/prisma#24269 to be merged as well as a fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores #4883 without any modifications.
Release pipeline is green again, so we should be ready to integrate it.
Original PR is work of @Druue, I am just a monkey pressing "revert"/"restore" buttons.