This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Introduce the Root Circuit to the integration tests #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CopyTable contains a BinaryNumberChip that uses a selector, but the load method doesn't enable the selector. The result of this is that when testing standalone circuits like the EVM circuit, the CopyTable will be included with a fixed column that is all zeroes. This causes problems when testing the EVM circuit with the Root aggregation circuit, because it doesn't support zeroed fixed columns. This commit should fix the problem.
github-actions
bot
added
CI
github-actions
bot
added
the
crate-bus-mapping
ed255
changed the title
|
Need 2 reviwers. The priority of this task is lower than word lo-hi |
han0110
approved these changes
Jun 16, 2023
Thanks for the hint! I've updated the tests in 93dddd2 to use degree=26 for Root Circuit with SuperCircuit and degree=24 for the other cases. |
CPerezz
approved these changes
Jun 17, 2023
Thanks for the suggestions! I've addressed them in 957f6bd |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce two new sets of tests in the Integration tests with the root circuit: one where the root circuit is verified with the MockProver and the other where a real proof is generated. The input proof to the root circuit is the output of each subcircuit test we had before.
Issue Link
Resolve #1334
Resolve #1460
Type of change
Contents
Issue #1335 has been resolved by assigning the fixed columns in the ExpTable and CopyTable in their
loadmethods. Previously they were either not assigned, or assigned dynamically. This was not affecting the SuperCircuit or the Exp/Copy Circuit because in those cases, the assignment is done with a different method. Only for SubCircuit tests where the SubCircuit requires the external table theloadmethod is used.Rationale
Testing a Root Circuit (no mater if it's with the MockProver or with a real proof) requires a real proof of the underlying circuit. This means that now for each SubCircuit we have 3 tests that require the SubCircuit proof:
I implemented a cache to keep the SubCircuit proofs for each SubCircuit and block so that we have the possibility of running all the tests in a single run while reusing the SubCircuit proofs.
How Has This Been Tested?
I have only tested the SubCircuits (minus SuperCircuit) + Root Circuit via MockProver.
But now we can run these tests under the github CI, so we can defer full testing after the PR is merged.