Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

feat/#1665 Precompile ECRECOVER #1720

Merged
merged 28 commits into from
Feb 19, 2024
Merged

feat/#1665 Precompile ECRECOVER #1720

merged 28 commits into from
Feb 19, 2024

Commits on Jan 26, 2024

  1. Precompile ECRECOVER (#529) 

    * feat: preliminary work

* wip

* finish assignment to ecrecover

* fix: input length may be different than call data length (for precompiles)

* fix: input bytes to ecrecover

* minor edits

* Fix ecrecover input rlc comparison (right-padding zeroes) (#585)

* potential approach (pow of rand lookup)

* add lookup for pow of rand

* fix: right pad only if needed

* fix: missing constraint on padded_rlc

* constrain pow of rand table

* Update step.rs

* fix: sig_v sanity check (remove assertions to allow garbage input)

* fix: calldata length == 0 handled

* chore: renaming precompile_* and parallel iter for tests

---------

Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>

Precompile ECRECOVER (#529)

* feat: preliminary work

* wip

* finish assignment to ecrecover

* fix: input length may be different than call data length (for precompiles)

* fix: input bytes to ecrecover

* minor edits

* Fix ecrecover input rlc comparison (right-padding zeroes) (#585)

* potential approach (pow of rand lookup)

* add lookup for pow of rand

* fix: right pad only if needed

* fix: missing constraint on padded_rlc

* constrain pow of rand table

* Update step.rs

* fix: sig_v sanity check (remove assertions to allow garbage input)

* fix: calldata length == 0 handled

* chore: renaming precompile_* and parallel iter for tests

---------

Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
    @roynalnaruto @lispc @KimiWu123
    2 people authored and KimiWu123 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    63c5439 View commit details
    Browse the repository at this point in the history

  2. ecrecover soundness (address not recovered) (#930) 

    * wip: preliminary work sig circuit/lookp

* feat: handle panics and edge cases in sig circuit

* fix: handle v not boolean

* fix: fq modulus not assigned and bus-mapping handle overflowing r/s

* fix: sig_v handle invalid values (lookup) and is_valid dev_load fix

* refactor (review comment)

* fix: no sig table lookup for invalid sig_v

* remove wrong test case (assertion fail)
    @roynalnaruto @KimiWu123
    roynalnaruto authored and KimiWu123 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    ffca5b9 View commit details
    Browse the repository at this point in the history

  3. fix: resolve build errors due to cherry-pick

    @KimiWu123
    KimiWu123 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    c0d6123 View commit details
    Browse the repository at this point in the history

  4. feat: compiling error free

    @KimiWu123
    KimiWu123 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    b76fd2f View commit details
    Browse the repository at this point in the history

  5. test: pass first basic testing

    @KimiWu123
    KimiWu123 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    2e72daf View commit details
    Browse the repository at this point in the history

  6. test: pass all testing for call, not for static_call, call_code and d… 

    …elegate_call yet
    @KimiWu123
    KimiWu123 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    5851481 View commit details
    Browse the repository at this point in the history

  7. test: pass all the normal testing

    @KimiWu123
    KimiWu123 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    831556d View commit details
    Browse the repository at this point in the history

  8. feat: support ecrecover oog case

    @KimiWu123
    KimiWu123 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    ce4d6a6 View commit details
    Browse the repository at this point in the history

  9. feat: upload missing ecc circult realted files

    @KimiWu123
    KimiWu123 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    187768e View commit details
    Browse the repository at this point in the history

  10. feat: commit missing sig_circuit

    @KimiWu123
    KimiWu123 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    ea52925 View commit details
    Browse the repository at this point in the history

  11. dep: add halo2-base and halo2-ecc as dependencies

    @KimiWu123
    KimiWu123 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    21d2d19 View commit details
    Browse the repository at this point in the history

  12. fix: build error due to importing halo2_ecc and halo2_base

    @KimiWu123
    KimiWu123 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    b88a8af View commit details
    Browse the repository at this point in the history

  13. feat: using sign_verify for sig_circuit, compilation error free

    @KimiWu123
    KimiWu123 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    2e2625c View commit details
    Browse the repository at this point in the history

  14. fix error due to rebase

    @KimiWu123
    KimiWu123 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    d0d3c4a View commit details
    Browse the repository at this point in the history

  15. Revert "feat: using sign_verify for sig_circuit, compilation error free" 

    This reverts commit 2e2625c.
    @KimiWu123
    KimiWu123 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    772ae18 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. feat: fixed all errors coming from sig_circuit merging

    @KimiWu123
    KimiWu123 committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    3dc90c3 View commit details
    Browse the repository at this point in the history

  2. test: all testing passed in sig_circuit

    @KimiWu123
    KimiWu123 committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    09dbea8 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. chore: fix clippy warnings

    @KimiWu123
    KimiWu123 committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    0e6ebbc View commit details
    Browse the repository at this point in the history

  2. feat: remove pow_of_rand_table

    @KimiWu123
    KimiWu123 committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    1cd2ac4 View commit details
    Browse the repository at this point in the history

  3. chore: fix clippy and wasm error

    @KimiWu123
    KimiWu123 committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    e308fc5 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. ci: set fixed number of threads for light unit test to avoid OOM

    @KimiWu123
    KimiWu123 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    fc1065c View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. chore: some leftovers

    @KimiWu123
    KimiWu123 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    4f09a7d View commit details
    Browse the repository at this point in the history

  2. test: split out a time-consuming test to a separated one

    @KimiWu123
    KimiWu123 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    359ad7e View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. chore: remove 'onephase' config and declare two constants for limbs

    @KimiWu123
    KimiWu123 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    aed502b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/#1665-ecrecover

    @KimiWu123
    KimiWu123 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    7af89c8 View commit details
    Browse the repository at this point in the history

  3. chore: fix typo as review feedback

    @KimiWu123
    KimiWu123 committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    4d5070f View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2024

  1. Merge remote-tracking branch 'origin/main' into feat/#1665-ecrecover

    @KimiWu123
    KimiWu123 committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    d6bc6c1 View commit details
    Browse the repository at this point in the history

  2. refactor to WordLoHi

    @KimiWu123
    KimiWu123 committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    a9858ef View commit details
    Browse the repository at this point in the history