Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest version of circle has moved the sound drivers #421

Closed
diyelectromusic opened this issue Jan 18, 2023 · 5 comments
Closed

Latest version of circle has moved the sound drivers #421

diyelectromusic opened this issue Jan 18, 2023 · 5 comments

Comments

@diyelectromusic
Copy link
Collaborator

The sound drivers in circle have moved to their own directory. This means updating minidexed.cpp, minidexed.h and Rules.mk to support the new libsound.a library in circle.
@diyelectromusic diyelectromusic mentioned this issue Jan 18, 2023
Merged
@diyelectromusic
Copy link
Collaborator Author

Looks like there is also an update to circle_stdlib_app.h which we copy from circle-stdlib (I don't know why we copy and not use it directly?). The circle-stdlib version has changed the call to CGlueStdioInit as per this commit: smuehlst/circle-stdlib@e880dc0

We need to port that over to MiniDexed circle_stdlib.app.h too in order to use the develop version of circle_stdlib.

@probonopd
Copy link
Owner

probonopd commented Jan 20, 2023 •
edited
Loading

Great point. Added that to the PR, fingers crossed :)

@diyelectromusic
Copy link
Collaborator Author

I think we've both done it - never mind! The commit history is going to get very "noisy"!! :)

@probonopd
Copy link
Owner

I think we've both done it

But yours is working - big difference ;-) 👍

probonopd added a commit that referenced this issue Jan 22, 2023
@diyelectromusic @probonopd
SSD1306 display rotation support and fix for #421 (#422)
fcea41e 
* Update Circle develop branch

for SSD1306 display rotation support

#412

* Implements rotation and mirroring options for SSD1306 displays (only). (#420)

Requires an update to circle (PR submitted to develop branch)

Co-authored-by: diyelectromusic <68612569+diyelectromusic@users.noreply.github.com>

* circle-stdlib e318f89

Needed to support Circle develop

* Fix for Issue 421 - circle sound drivers have moved to their own subdirectory and library.

* Updated to keep in step with updates from the original in circle-stdlib.

* git checkout circle-newlib 48bf91d 

Needed for circle ec09d7e

Co-authored-by: probonopd <probonopd@users.noreply.github.com>
@diyelectromusic
Copy link
Collaborator Author

This update has been incorporated into #422 so I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@probonopd @diyelectromusic