SSD1306 display rotation support and fix for #421 #422

diyelectromusic · 2023-01-18T21:39:14Z

Fix for Issue #421 - circle sound drivers have moved to their own subdirectory and library.

for SSD1306 display rotation support probonopd#412

probonopd#420) Requires an update to circle (PR submitted to develop branch) Co-authored-by: diyelectromusic <68612569+diyelectromusic@users.noreply.github.com>

Needed to support Circle develop?

…irectory and library.

diyelectromusic · 2023-01-18T21:46:35Z

This will need the latest develop branch of circle of course...

probonopd · 2023-01-20T18:14:04Z

In file included from kernel.h:23,
                 from kernel.cpp:20:
circle_stdlib_app.h: In member function 'virtual bool CStdlibAppStdio::Initialize()':
circle_stdlib_app.h:218:33: error: invalid initialization of reference of type 'CConsole&' from expression of type 'FATFS'
  218 |                 CGlueStdioInit (mFileSystem, mConsole);
      |                                 ^~~~~~~~~~~

…to Issue421Fix

probonopd · 2023-01-20T19:45:49Z

It built 👍

Let's test it:
MiniDexed_2023-01-20-d0b139c

diyelectromusic · 2023-01-20T19:55:11Z

I get an assertion failing in circle-stdlib/libs/circle-newlib/libgloss/circle/io.cpp(687): circle_fat_fs

There was a corresponding update to newlib as well as stdlib so are you using the develop version of that too?

diyelectromusic · 2023-01-20T19:56:37Z

Yep, looks like we need this too: smuehlst/circle-newlib@48bf91d

probonopd · 2023-01-20T20:00:04Z

Can you spot where we are pulling in circle-newlib? I don't see where I could change it...

diyelectromusic · 2023-01-20T20:04:58Z

I believe it is one of the sub-modules for circle_stdlib, alongside circle itself...?

diyelectromusic · 2023-01-20T20:08:15Z

Yes, so in the build.yml I guess we need to add something to also checkout the develop branch of newlib alongside circle (after checking out the develop branch of circle-stdlib itself)?

probonopd · 2023-01-21T11:29:21Z

Indeed. Submodules are pulling in other submodules.

Needed for circle ec09d7e

probonopd · 2023-01-21T11:43:57Z

@diyelectromusic how does MiniDexed_2023-01-21-63fac3c look?

probonopd · 2023-01-21T12:02:21Z

Reminder to self, also need to add descriptions for

SSD1306LCDRotate=0
SSD1306LCDMirror=0

to the wiki. I wonder whether someone will come up with a cool HW project using the mirror feature ;-)

@diyelectromusic which values are allowed for these, just 0 and 1?

diyelectromusic · 2023-01-21T13:59:22Z

That seems to have done the trick! :)

Phew, that was a lot more complicated than it should have been!!

Kevin

diyelectromusic · 2023-01-21T14:00:33Z

@diyelectromusic which values are allowed for these, just 0 and 1?

Actually 0 and <>0 - I think that is the same as other boolean values in the config file...

probonopd · 2023-01-21T14:04:52Z

OK, for simplicty let's document it as 0/1 then.

Thanks a lot for your help!

Awaiting @vujnovich's response, will then merge.

vujnovich · 2023-01-21T20:22:02Z

So is the setting in the ini file to toggle the flip? I hadn't downloaded it and checked . I'll give it a go a bit later. Again. Thanks for the work you put into this project

…

On Sat, Jan 21, 2023, 12:18 PM probonopd ***@***.***> wrote: OK, for simplicty let's document it as 0/1 then. Thanks a lot for your help! Awaiting @vujnovich <https://github.com/vujnovich>'s response, will then merge. — Reply to this email directly, view it on GitHub <#422 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AP6HDJLMH2O3GVKYHWI4BADWTQK4PANCNFSM6AAAAAAT7SZA6M> . You are receiving this because you were mentioned.Message ID: ***@***.***>

probonopd · 2023-01-21T20:33:15Z

Yes, please try it out and let us know whether it works for you. Thanks!

Banana71 · 2023-01-22T05:26:11Z

Moin,
You've done a lot of good there :-)
SSD1306LCDRotate & SSD1306LCDMirror work perfectly.
But why does the mirror effect work over the short axis? I would have expected mirroring over the long axis, similar to a head-up display in a car.
All other functions on the MiniDexed work as usual.

diyelectromusic · 2023-01-22T09:41:50Z

But why does the mirror effect work over the short axis?

As the starting point was MT32-Pi I just ported over the two modes it already uses. I had a quick look at the ssd1306 datasheet, but haven't fully decoded the registers to know if there are additional feasible modes. But now it all looks up and running I might take a look again at some point...

Update: Thinking a little more - isn't this what Mirrored + Rotated does? Now I'm really confused! :)

Update again: Actually mirrored can be viewed in a mirror in either axis regardless!? Or am I missing something (highly likely)?

This is Mirrored = 1; Rotated = 0 :)

Final Thought: I think there is where I defer to "Physics Girl" - https://www.youtube.com/watch?v=vBpxhfBlVLU :)

Kevin

probonopd · 2023-01-22T10:15:06Z

Yes, if you mirror something along the x-axis and then rotate it by 180 degrees, the final result will be the same as if you had just mirrored it along the y-axis.

We should test and put this into the documentation. Is the following correct?

To rotate the display by 180 degrees, set SSD1306LCDRotate=1
To mirror the display along the short axis, set SSD1306LCDMirror=1
To mirror the display along the long axis, set SSD1306LCDMirror=1 and SSD1306LCDRotate=1

diyelectromusic · 2023-01-22T10:31:29Z

We should test and put this into the documentation. Is the following correct?

I think we're saying:

To rotate the display by 180 degrees, set SSD1306LCDRotate=1
To mirror the display set SSD1306LCDMirror=1

Note that a mirrored display will be the same orientation when viewed mirrored via the short axis, but upside down when viewed mirrored via the long axis. For a "heads up display" style effect it would need to be both mirrored and rotated.

Banana71 · 2023-01-22T11:26:58Z

Haha,
with 2 bits you can represent 4 possibilities.
Now everything is clear, it was still very early in the morning when I tried it out. It's my pleasure to cause confusion.
Good that we talked about it, all ambiguities have been eliminated :-D

probonopd · 2023-01-22T13:32:04Z

Also added to documentation.

Again, thank you very, very much @diyelectromusic 👍

diyelectromusic · 2023-01-22T13:52:10Z

We've made it! Hurrah! :)

vujnovich · 2023-01-23T20:04:52Z

So I just had the time to try the new build. Looking at the config, I noticed the lcd mirror option is in the ssd1306 , not the hd44780. Bah, I'm gonna try it anyway 😜. Suppose I didn't mention I was using the hd44780 with a backpack. Anyway cheers

…

On Sun, Jan 22, 2023, 8:52 AM Kevin ***@***.***> wrote: We've made it! Hurrah! :) — Reply to this email directly, view it on GitHub <#422 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AP6HDJMBLHNWJF3GBUF4SL3WTU3RLANCNFSM6AAAAAAT7SZA6M> . You are receiving this because you were mentioned.Message ID: ***@***.***>

diyelectromusic · 2023-01-23T20:44:46Z

So I just had the time to try the new build. Looking at the config, I noticed the lcd mirror option is in the ssd1306 , not the hd44780. Bah, I'm gonna try it anyway 😜. Suppose I didn't mention I was using the hd44780 with a backpack. Anyway cheers

I thought you'd said you'd tried it with MT32-Pi and wondered if we could do the same. MT32-Pi can only rotate a SSD1306 based display too (well, actually it might support other "graphical" displays, but ssd1306 is the only one we do too).

The hd44780 is not a "graphical" display and support in MT32-Pi can't rotate either, so I didn't bother even looking...

Kevin

probonopd and others added 4 commits January 18, 2023 20:40

Update Circle develop branch

ab8deb0

for SSD1306 display rotation support probonopd#412

Implements rotation and mirroring options for SSD1306 displays (only). (

29193db

probonopd#420) Requires an update to circle (PR submitted to develop branch) Co-authored-by: diyelectromusic <68612569+diyelectromusic@users.noreply.github.com>

circle-stdlib e318f89

5bb00fb

Needed to support Circle develop?

Fix for Issue 421 - circle sound drivers have moved to their own subd…

97f48f9

…irectory and library.

probonopd added 3 commits January 20, 2023 18:03

Merge branch 'SSD1306-rotation' into Issue421Fix

6469ad0

Merge branch 'main' into Issue421Fix

730c501

Merge branch 'main' into SSD1306-rotation

77ad300

diyelectromusic added 3 commits January 20, 2023 19:09

Merge branch 'SSD1306-rotation' into Issue421Fix

6f39384

Updated to keep in step with updates from the original in circle-stdlib.

3a068d1

Merge branch 'Issue421Fix' of github.com:diyelectromusic/MiniDexed in…

67a69b8

…to Issue421Fix

probonopd mentioned this pull request Jan 20, 2023

SSD1306 display rotation support #419

Closed

probonopd changed the title ~~Fix for Issue #421~~ SSD1306 display rotation support and fix for Issue #421 Jan 20, 2023

probonopd changed the title ~~SSD1306 display rotation support and fix for Issue #421~~ SSD1306 display rotation support and fix for #421 Jan 20, 2023

git checkout circle-newlib 48bf91d

ac416a8

Needed for circle ec09d7e

Merge branch 'main' into Issue421Fix

d806699

probonopd merged commit fcea41e into probonopd:main Jan 22, 2023

diyelectromusic mentioned this pull request Jan 22, 2023

Latest version of circle has moved the sound drivers #421

Closed

diyelectromusic deleted the Issue421Fix branch January 22, 2023 13:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SSD1306 display rotation support and fix for #421 #422

SSD1306 display rotation support and fix for #421 #422

diyelectromusic commented Jan 18, 2023

diyelectromusic commented Jan 18, 2023

probonopd commented Jan 20, 2023

probonopd commented Jan 20, 2023

diyelectromusic commented Jan 20, 2023

diyelectromusic commented Jan 20, 2023

probonopd commented Jan 20, 2023

diyelectromusic commented Jan 20, 2023

diyelectromusic commented Jan 20, 2023

probonopd commented Jan 21, 2023

probonopd commented Jan 21, 2023

probonopd commented Jan 21, 2023 •

edited

Loading

diyelectromusic commented Jan 21, 2023

diyelectromusic commented Jan 21, 2023

probonopd commented Jan 21, 2023 •

edited

Loading

vujnovich commented Jan 21, 2023 via email

probonopd commented Jan 21, 2023

Banana71 commented Jan 22, 2023 •

edited

Loading

diyelectromusic commented Jan 22, 2023 •

edited

Loading

probonopd commented Jan 22, 2023 •

edited

Loading

diyelectromusic commented Jan 22, 2023

Banana71 commented Jan 22, 2023 •

edited

Loading

probonopd commented Jan 22, 2023 •

edited

Loading

diyelectromusic commented Jan 22, 2023

vujnovich commented Jan 23, 2023 via email

diyelectromusic commented Jan 23, 2023

SSD1306 display rotation support and fix for #421 #422

SSD1306 display rotation support and fix for #421 #422

Conversation

diyelectromusic commented Jan 18, 2023

diyelectromusic commented Jan 18, 2023

probonopd commented Jan 20, 2023

probonopd commented Jan 20, 2023

diyelectromusic commented Jan 20, 2023

diyelectromusic commented Jan 20, 2023

probonopd commented Jan 20, 2023

diyelectromusic commented Jan 20, 2023

diyelectromusic commented Jan 20, 2023

probonopd commented Jan 21, 2023

probonopd commented Jan 21, 2023

probonopd commented Jan 21, 2023 • edited Loading

diyelectromusic commented Jan 21, 2023

diyelectromusic commented Jan 21, 2023

probonopd commented Jan 21, 2023 • edited Loading

vujnovich commented Jan 21, 2023 via email

probonopd commented Jan 21, 2023

Banana71 commented Jan 22, 2023 • edited Loading

diyelectromusic commented Jan 22, 2023 • edited Loading

probonopd commented Jan 22, 2023 • edited Loading

diyelectromusic commented Jan 22, 2023

Banana71 commented Jan 22, 2023 • edited Loading

probonopd commented Jan 22, 2023 • edited Loading

diyelectromusic commented Jan 22, 2023

vujnovich commented Jan 23, 2023 via email

diyelectromusic commented Jan 23, 2023

probonopd commented Jan 21, 2023 •

edited

Loading

probonopd commented Jan 21, 2023 •

edited

Loading

Banana71 commented Jan 22, 2023 •

edited

Loading

diyelectromusic commented Jan 22, 2023 •

edited

Loading

probonopd commented Jan 22, 2023 •

edited

Loading

Banana71 commented Jan 22, 2023 •

edited

Loading

probonopd commented Jan 22, 2023 •

edited

Loading