handle positions of elements after a split #22
Conversation
To do that, add rows above and below the element that have multiple outgoing transition and then put each of the next element right of the it. Still not handled: * Elements that split + join * Overlapping of successive branches * Joins should be align to its split element Added in this PR a ASCII exported to have a visual feedback when assertions are failing (try to change an assert in ShapeLayouterTest) Closes #9
| import io.process.analytics.tools.bpmn.generator.model.Grid; | ||
| import io.process.analytics.tools.bpmn.generator.model.Position; | ||
|
|
||
| public class ASCIIExporter { |
There was a problem hiding this comment.
👍 like the idea to get feedbacks on failing tests
java/src/main/java/io/process/analytics/tools/bpmn/generator/algo/ShapeLayouter.java
Outdated
Show resolved
Hide resolved
| } | ||
| List<Edge> outgoingEdges = diagram.getOutgoingEdges(shape.getId()); | ||
| if (outgoingEdges.size() > 1) { | ||
| //add rows to place elements of this split |
There was a problem hiding this comment.
❓ I may be messed by the comment about the split
at a 1st glance, this is strange to have something which is always run but which only relates to split
What I understood is that you always add rows to manage eventual splits. Is that correct?
There was a problem hiding this comment.
At first, I started adding rows when adding the elements after the split:
i.e. when calling the addSplit method, I was adding rows to handle all elements.
Finally, I found it easier to add the rows when we are processing the elements that have multiple outgoing transitions.
I did not understood that we always add rows to manage an eventual split. It's only written that we need to add rows to put all elements after a split. It's not written how we do it.
We should check the implementation in oryx to see how they handled that.
There was a problem hiding this comment.
ok, thanks for the info
As it is working for now, we can live with it (at least it is not a problem to me)
Co-authored-by: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com>
To do that, add rows above and below the element that have multiple
outgoing transition and then put each of the next element right of the
it.
Still not handled:
Added in this PR a ASCII exported to have a visual feedback when
assertions are failing (try to change an assert in ShapeLayouterTest)
Closes #9