feat(converter): transform bpmn model into algorithms model #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
force-pushed
the
feat/gh-13-transform_bpmn_model_into_algorithms_model
branch
4 times, most recently
from
c971707 to
c59575c
Compare
tbouffard
requested review from
baptistemesta and
oanesini
and removed request for
baptistemesta
tbouffard
changed the title
baptistemesta
approved these changes
May 1, 2020
|
|
||
| bpmnElements.getSequenceFlows().stream() | ||
| .map(seqFlow -> new Edge(getId(seqFlow.getSourceRef()), getId(seqFlow.getTargetRef()))) | ||
| .forEach(diagram::edge); |
| @Test | ||
| public void main_generates_svg_output_file() throws Exception { | ||
| String outputPath = outputPath("A.2.0_with_diagram.bpmn.svg"); | ||
| generateToSvg(inputPath("A.2.0.bpmn.xml"), outputPath); |
There was a problem hiding this comment.
ℹ️ IMO splitting logic of the App in 2 would help to make theses test more readable:
- Having on one part logic to parse options of the app and read the file given
- Having in another class logic to take the content of the BPMN and outputting the layout.
We should do that at some point.
There was a problem hiding this comment.
yes, the App class is a mess, it is a little bit better in #25
i didn't want to work on it for now, but for sure, there is a lot to improve here 😺
There was a problem hiding this comment.
I was just putting my though here for the next steps :). But yep! this can be merged as soon as the other is merged.
baptistemesta
force-pushed
the
feat/gh-13-transform_bpmn_model_into_algorithms_model
branch
from
c59575c to
a4bfc9c
Compare
|
I took the liberty to rebase it on master! |
baptistemesta
deleted the
feat/gh-13-transform_bpmn_model_into_algorithms_model
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #22: to get the AsciiExporter
This PR let you load a BPMN file, pass data through the algorithm and export the result to an ASCII or SVG file.
The BPMN output export will be manage in another PR as it requires extra conversion from internal model to BPMN.
Notice that this is the initial support for BPMN load, there is no management of lane or laneset. This should only work with process without such elements.
Here is the SVG render when loading the A.2.0.bpmn file from BPMN-MIWG
Covers #13