-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(converter): transform algorithms model into bpmn model #25
Merged
tbouffard
merged 17 commits into
master
from
feat/gh-13-transform_algorithms_model_into_bpmn_model
May 6, 2020
Merged
feat(converter): transform algorithms model into bpmn model #25
tbouffard
merged 17 commits into
master
from
feat/gh-13-transform_algorithms_model_into_bpmn_model
May 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have them, this generates an invalid bpmn file (waypoints are mandatory) but BPMN tools generally can manage this.
tbouffard
force-pushed
the
feat/gh-13-transform_algorithms_model_into_bpmn_model
branch
from
May 2, 2020 22:14
2896ce7
to
6890f49
Compare
tbouffard
deleted the
feat/gh-13-transform_algorithms_model_into_bpmn_model
branch
May 6, 2020 13:49
This was referenced May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the render when loading the A.2.0.bpmn file from BPMN-MIWG
Generated BPMN file: A.2.0_generated_diagram.bpmn.zip
Implementation notes
Initial shapes and edges
bpmn-visualization-js 0.1.3-dev
The cross in the exclusive gateway is too large, this is due to the lib (still under development) not to the generated file
The events shapes are ellipse because this is generated like this in the file
Notice that, even if there are no waypoints, the edges stop on the border of the shapes
demo.bpmn.io (bpmn-js 6.5.1)
The event shapes are circles because the lib enforces it.
The edges go to the center of the shapes (no waypoints).