feat(render): adjust exported gateways and events shape and size #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
force-pushed
the
feat/adjust_exported_shape_and_size_of_gateways_and_events
branch
from
1b152ee to
da883cb
Compare
Optimized for bpmn export For svg export, this required additional adjustments directly in the in the svg exporter
tbouffard
changed the title
|
That's beautiful! |
| // ensure to have a square shape (i.e. same width and height) for non activity elements | ||
| ShapeType shapeType = shape.getType(); | ||
| if (shapeType == ShapeType.EVENT || shapeType == ShapeType.GATEWAY) { | ||
| int nodeDimension = Math.min(nodeWidth, nodeHeight); |
baptistemesta
approved these changes
May 15, 2020
baptistemesta
deleted the
feat/adjust_exported_shape_and_size_of_gateways_and_events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement of the initial implementation provided by #25
The dimensions of the gateways and events have been improved (width and height are the same), the label positions have also been adjusted for these BPMN elements
Screenshots with A.2.0.bpmn file from BPMN-MIWG
Notice that comparing to the #25 rendering, the sort algorithm has switched
Task 2andTask 4, so the edge fromTask 2to theend eventoverlaps the final gatewaysvg export
It now identifies gateways and events
bpmn-visualization-js (0.1.3 dev commit 1172325)
Label positions from the BPMN file are not used for rendering, the lib currently used arbitrary positions
demo.bpmn.io (bpmn-js@6.5.1)
Label positions are taken from the BPMN file