-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring test_collections folder #10
Refactoring test_collections folder #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to keep a clear separation of content tracked in this repo and content pulled form the SDK repo.
I suggest that we organize it like this:
test_collections/sdk_tests/sdk_checkout/
is the only place we put content from SDK, and it only contains content from the SDKtest_collections/sdk_tests/support
could contain all the python code we need in our repo, for yaml models etc. But no code from the SDK repo.
This way we can simply delete sdk_checkout
when we need to update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
But I think we can simplify the excluding of test_collections/sdk_tests/sdk_checkout
What changed
This PR is the phase-1 for the feature Python tests in TH UI.
The motivation to refactoring is to prepare the code to retrieve the python tests from SDK.
The final proposal for the folders organization is described bellow (PS: python_testing folder is part of phase 2):
Related Issues
Python tests in TH UI - Phase 1 (Refactoring test_collection folder) - project-chip/certification-tool#72
Testing