Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring test_collections folder #10

Conversation

rquidute
Copy link
Contributor

@rquidute rquidute commented Oct 27, 2023

What changed

This PR is the phase-1 for the feature Python tests in TH UI.
The motivation to refactoring is to prepare the code to retrieve the python tests from SDK.
The final proposal for the folders organization is described bellow (PS: python_testing folder is part of phase 2):

  • test_collections
    • sample_tests
    • python_tests
    • sdk_tests
      • sdk_checkout
        • .version
        • yaml_tests
          • yaml
        • python_testing
          • script
        • sdk_runner
      • support
        • yaml_tests
          • models
        • python_testing
          • models
        • init.py

Related Issues

Python tests in TH UI - Phase 1 (Refactoring test_collection folder) - project-chip/certification-tool#72

Testing

  • Unit test updated and passing
Screenshot 2023-10-27 at 15 47 47
  • Test case execution successfully in TH (Automated, Semi-Automated, Simulated, Manual)

@rquidute rquidute self-assigned this Oct 27, 2023
@rquidute rquidute changed the title Refactoring test collections folder Refactoring test_collections folder Oct 27, 2023
@rquidute rquidute changed the title Refactoring test_collections folder WIP: Refactoring test_collections folder Oct 27, 2023
Copy link
Contributor

@mikaelhm mikaelhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to keep a clear separation of content tracked in this repo and content pulled form the SDK repo.

I suggest that we organize it like this:

  • test_collections/sdk_tests/sdk_checkout/ is the only place we put content from SDK, and it only contains content from the SDK
  • test_collections/sdk_tests/support could contain all the python code we need in our repo, for yaml models etc. But no code from the SDK repo.

This way we can simply delete sdk_checkout when we need to update.

@rquidute rquidute changed the title WIP: Refactoring test_collections folder Refactoring test_collections folder Oct 27, 2023
@rquidute rquidute requested a review from mikaelhm October 27, 2023 22:01
Copy link
Contributor

@mikaelhm mikaelhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

But I think we can simplify the excluding of test_collections/sdk_tests/sdk_checkout

.flake8 Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
cspell.json Outdated Show resolved Hide resolved
@rquidute rquidute merged commit 004928a into project-chip:main Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants