Fix problem with sdk_tests collection using hardcoded paths #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelhm
changed the title
fabiowmm
approved these changes
Nov 7, 2023
raju-apple
approved these changes
Nov 7, 2023
After updating to the new changes I ran into the problem that the test cases do not appear in production mode so I moved to this branch to verify it and it works correctly. 
What I did to test it was add the fork branch to the current backend (
|
gvargas-csa
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #10 and #14 was merged, we introduced a problem where the SDK tests only worked when running the backend in developer mode.
Specially, the problem stems from the fact that we used
/app/backedhardcoded paths:https://github.com/project-chip/certification-tool-backend/pull/10/files#diff-aea3c8e66d486bcaf287e7c19fa77772d3f40ac9733ee99c465657afda4104d5L41
And that only works in dev mode.
This PR changes this back to using relative paths.