Skip to content

Commit

Permalink
Rename HasEventWildcard to IsWildcardPath. (#27105)
Browse files Browse the repository at this point in the history
This is checking for wildcard endpoints/clusters too, so HasEventWildcard is pretty misleading.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Jan 4, 2024
1 parent d1c6cde commit 3966647
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/app/EventPathParams.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ struct EventPathParams
return other.mEndpointId == mEndpointId && other.mClusterId == mClusterId && other.mEventId == mEventId;
}

bool HasEventWildcard() const { return HasWildcardEndpointId() || HasWildcardClusterId() || HasWildcardEventId(); }
bool IsWildcardPath() const { return HasWildcardEndpointId() || HasWildcardClusterId() || HasWildcardEventId(); }

// For event, an event id can only be interpreted if the cluster id is known.
bool IsValidEventPath() const { return !(HasWildcardClusterId() && !HasWildcardEventId()); }
Expand Down
2 changes: 1 addition & 1 deletion src/app/reporting/Engine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ CHIP_ERROR Engine::CheckAccessDeniedEventPaths(TLV::TLVWriter & aWriter, bool &
CHIP_ERROR err = CHIP_NO_ERROR;
for (auto current = apReadHandler->mpEventPathList; current != nullptr;)
{
if (current->mValue.HasEventWildcard())
if (current->mValue.IsWildcardPath())
{
current = current->mpNext;
continue;
Expand Down

0 comments on commit 3966647

Please sign in to comment.